Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use existing scc instance #221

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: use existing scc instance #221

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3175d0d
feat: use existing scc instance
kierramarie Oct 22, 2024
bea5ab9
Merge branch 'main' into ks-update-scc
kierramarie Nov 13, 2024
fcc4f2d
Merge branch 'main' into ks-update-scc
kierramarie Dec 11, 2024
a928ad5
fix: added new var to catalog json
kierramarie Dec 12, 2024
ad1e41f
test: add scc to existing resources test
kierramarie Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,13 @@
"description": "The CRN of an existing event notification instance to use in this solution. If not set, a new event notification instance is provisioned.",
"required": false
},
{
"key": "existing_scc_instance_crn",
"type": "string",
"default_value": "__NULL__",
"description": "The CRN of an existing security and compliance center instance to use in this solution. If not set, a new security and compliance center instance is provisioned.",
"required": false
},
{
"key": "existing_discovery_instance",
"type": "string",
Expand Down
11 changes: 11 additions & 0 deletions solutions/basic/stack_definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@
"hidden": false,
"default": null
},
{
"name": "existing_scc_instance_crn",
"required": false,
"type": "string",
"hidden": false,
"default": null
},
{
"name": "existing_event_notification_instance_crn",
"required": false,
Expand Down Expand Up @@ -384,6 +391,10 @@
"name": "resource_group_name",
"value": "ref:../Account Infrastructure Base/outputs/audit_resource_group_name"
},
{
"name": "existing_scc_instance_crn",
"value": "ref:../../inputs/existing_scc_instance_crn"
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../Essential Security - Encryption Key Management/outputs/kms_instance_crn"
Expand Down
11 changes: 11 additions & 0 deletions solutions/standard/stack_definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@
"hidden": false,
"default": null
},
{
"name": "existing_scc_instance_crn",
"required": false,
"type": "string",
"hidden": false,
"default": null
},
{
"name": "existing_event_notification_instance_crn",
"required": false,
Expand Down Expand Up @@ -384,6 +391,10 @@
"name": "resource_group_name",
"value": "ref:../Account Infrastructure Base/outputs/audit_resource_group_name"
},
{
"name": "existing_scc_instance_crn",
"value": "ref:../../inputs/existing_scc_instance_crn"
},
{
"name": "existing_kms_instance_crn",
"value": "ref:../Essential Security - Encryption Key Management/outputs/kms_instance_crn"
Expand Down