Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use existing scc instance #221

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: use existing scc instance #221

wants to merge 5 commits into from

Conversation

kierramarie
Copy link

Description

Updated version locator to newest version of SCC and included variable for existing SCC instance.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Author

/run pipeline

@kierramarie
Copy link
Author

Test failed because of projects limit, but the SCC part of the project was successfully deployed.

@kierramarie
Copy link
Author

/run pipeline

@ocofaigh
Copy link
Member

@kierramarie what happened to to this one?

@kierramarie
Copy link
Author

kierramarie commented Dec 11, 2024

/run pipeline

@ocofaigh
Copy link
Member

@kierramarie editing the comment wont trigger pipeline. Needs a new comment. I'll leave one now to trigger..

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but first it seems as if your missing the new variable in the ibm_catalog.json

@kierramarie
Copy link
Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the existing resources test to test existing SCC so we test the feature in the stack?

PS: Projects seems a little unstable at the moment so I suspect thats why tests are failing. Lets see what tests look like after your next commit

@kierramarie
Copy link
Author

/run pipeline

@kierramarie
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants