-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use existing scc instance #221
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
Test failed because of projects limit, but the SCC part of the project was successfully deployed. |
/run pipeline |
@kierramarie what happened to to this one? |
/run pipeline |
@kierramarie editing the comment wont trigger pipeline. Needs a new comment. I'll leave one now to trigger.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh but first it seems as if your missing the new variable in the ibm_catalog.json
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the existing resources test to test existing SCC so we test the feature in the stack?
PS: Projects seems a little unstable at the moment so I suspect thats why tests are failing. Lets see what tests look like after your next commit
/run pipeline |
Description
Updated version locator to newest version of SCC and included variable for existing SCC instance.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers