-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast failing test in ci #1666
Merged
seanpmorgan
merged 13 commits into
tensorflow:master
from
gabrieldemarmiesse:fast_failing_test_in_CI
Apr 17, 2020
Merged
Fast failing test in ci #1666
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
35b319c
Added a pytest option to skip the loading of custom ops.
gabrieldemarmiesse a089237
Added a ci run for python-only tests.
gabrieldemarmiesse 94db295
Fix the usage of load_op_library.
gabrieldemarmiesse 388f05a
Revert "Fix the usage of load_op_library."
gabrieldemarmiesse b933b4f
Fixture is executed after collection.
gabrieldemarmiesse 17d44c1
Removed assert False.
gabrieldemarmiesse a08d967
Try running on macos for speed.
gabrieldemarmiesse 40aa7a4
Fix path.
gabrieldemarmiesse 9d1c58b
Run on ubuntu directly.
gabrieldemarmiesse 97d8493
Add caching for pip.
gabrieldemarmiesse 9b7ce3f
Indent.
gabrieldemarmiesse b78fe13
Better wording.
gabrieldemarmiesse 0083239
Remove the cache because we don't get any benefits.
gabrieldemarmiesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any speedup caching pip packages? https://github.com/actions/cache/blob/master/examples.md#simple-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but I removed it in 0083239 because we didn't get any speed benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried another build After the cache build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can take a look for yourself since the build logs are public for each commit. If I missed something, please let me know.