Fast failing test in ci #1666
Merged
Fast failing test in ci #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhack
reviewed
Apr 15, 2020
| with: | ||
| python-version: 3.5 | ||
| - uses: actions/checkout@v2 | ||
| - run: pip install -r tools/install_deps/tensorflow-cpu.txt -r tools/install_deps/pytest.txt |
There was a problem hiding this comment.
Any speedup caching pip packages? https://github.com/actions/cache/blob/master/examples.md#simple-example
There was a problem hiding this comment.
I tried, but I removed it in 0083239 because we didn't get any speed benefits.
There was a problem hiding this comment.
Have you tried another build After the cache build?
There was a problem hiding this comment.
Yes, you can take a look for yourself since the build logs are public for each commit. If I missed something, please let me know.
seanpmorgan
approved these changes
Apr 17, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added a pytest option to skip the loading of custom ops. * Added a ci run for python-only tests. * Fix the usage of load_op_library. * Revert "Fix the usage of load_op_library." This reverts commit 94db295. * Fixture is executed after collection. * Removed assert False. * Try running on macos for speed. * Fix path. * Run on ubuntu directly. * Add caching for pip. * Indent. * Better wording. * Remove the cache because we don't get any benefits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1655
So of course this doesn't make our CI any faster, but it provides fast feedback for contributors. With this new test, we catch most of the errors quickly since many changes are related to python-only code. The test runs in 4m and 20s, much faster than the 11m and 25s needed to run our fastest test (macos).
Some ressources: