Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar accessibility #45

Merged
merged 4 commits into from
Nov 13, 2019

Commits on Oct 21, 2019

  1. Search bar accessibility improvements.

    - all inputs should have labels
      - eliminated placeholder, which should only be used for examples
      - simulated placeholder interaction (disappear on input)
      - for usability, I don't think we should hide the label, but I'm
        not trying to redesign here
    - focus highlight for locate button now surrounds the whole icon
      - this shifts the button's position slightly but I think it's fine
    - added alt text to locate icon
    
    Also removed `console.log` which probably shouldn't be in production.
    
    This fixes some of the low-hanging WCAG fruit (techforwarren#23).
    eostrom committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    e4c471b View commit details
    Browse the repository at this point in the history
  2. Added (empty) alt text to landing page icon.

    The icon after "SHE HAS A PLAN FOR THAT" doesn't have any semantic
    content, it's just decorative. I added an empty alt text so that
    accessibility checkers will know it's empty on purpose.
    eostrom committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    26eab0a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Configuration menu
    Copy the full SHA
    5b8a457 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cfb8635 View commit details
    Browse the repository at this point in the history