Search bar accessibility #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all inputs should have labels
- eliminated placeholder, which should only be used for examples
- simulated placeholder interaction (disappear on input)
- for usability, I don't think we should hide the label, but I'm
not trying to redesign here
- focus highlight for locate button now surrounds the whole icon
- this shifts the button's position slightly but I think it's fine
- added alt text to locate icon
Also removed `console.log` which probably shouldn't be in production.
This fixes some of the low-hanging WCAG fruit (techforwarren#23).
The icon after "SHE HAS A PLAN FOR THAT" doesn't have any semantic content, it's just decorative. I added an empty alt text so that accessibility checkers will know it's empty on purpose.
eostrom
force-pushed
the
search-bar-accessibility
branch
from
2ca3e89
to
26eab0a
Compare
|
Hey Erik! Love these changes - will do a quick code review as soon as I can and merge it in. Thanks for tackling these low hanging fruit items so quickly 👊🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
console.logwhich probably shouldn't be in production.This fixes some of the low-hanging WCAG fruit (#23). I also added (empty) alt text to the landing page icon, so that accessibility checkers know that image is semantically empty on purpose.