[๐จ fix/#140] ๊ฒ์ํ๋ฉด totalPages, totalCount ๋ฐ์ดํฐ ๋ถ์ ํํ ์ค๋ฅ ์์ ๋ฐ count ์ฟผ๋ฆฌ ์ฑ๋ฅ ๊ฐ์ #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Work Description
โ๏ธ ISSUE
๐ท Screenshot
๐ฌ To Reviewers
๐ ๋ก์ปฌ์์๋ ์ ๋๋ ๊ฒ ํ์ธํ๋๋ฐ, ์คํ ์ด์ง ์๋ฒ์ ๋จธ์งํ๊ณ ์ ๋๋์ง ์ถ๊ฐ๋ก ํ์ธ์ ํด๋ด์ผํ ๊ฒ ๊ฐ์ต๋๋ค!
1. ๊ฒ์ํ๋ฉด์์ totalPages์ totalCount ์๊ฐ ์ ํํ ์ ๋ฌ๋์ง ์์๋ ์์ธ์ ์๋์ ๊ฐ์ต๋๋ค.
InternshipAnnounctment
์scrap
์fetchjoin()
์ผ๋ก ์กฐํํ๊ณ ์ ํ๋๋ฐ,fetchjoin()
์ด ๋ด๋ถ์ ์ผ๋กinnerjoin()
์ ์ฌ์ฉํ๊ธฐ ๋๋ฌธ์ ์ค๋ณต๋ ๋ฐ์ดํฐ๊ฐ ๋ฐ์ํ์์ต๋๋ค! (์ฐธ๊ณ ๋ธ๋ก๊ทธ)distinct()
์ฌ์ฉ์ ํตํ ๋ฐ์ดํฐ ์ค๋ณต์ ๊ฑฐfetchjoin()
์ ๊ฑฐ๋ฅผ ํตํ ๋ฐ์ดํฐ ์ค๋ณต์ ๊ฑฐ์์ 2๊ฐ์ง ํด๊ฒฐ ๋ฐฉ์ ์ค ์ ๋ 2๋ฒ์ ์ ํํ์ต๋๋ค! ํด๋น ๋ฐฉ์์ ์ ํํ ์ด์ ๋ ์๋์ ๊ฐ์ต๋๋ค.
N+1
๋ฌธ์ ๊ฐ ๋ฐ์ํ์ง ์๋ ๊ฒ์ ํ์ธํ์ฌ,fetchjoin()
์ ๊ตณ์ด ์ฌ์ฉํ์ง ์์๋ ๋ ๊ฒ ๊ฐ๋ค๋ ์๊ฐ์ ๋๋ค!2.
PageableExecutionUtils
์ฌ์ฉ์ ํตํcount
์ฟผ๋ฆฌ ์ฑ๋ฅ ๊ฐ์PageImpl
์ ์ฌ์ฉํ์ฌtotalCount
๋ฅผ ์กฐํํ๋ ๊ฒ์์PageableExecutionUtils
๋ฅผ ์ฌ์ฉํ์ฌ ์ฑ๋ฅ์ ๊ฐ์ ํ์ต๋๋ค.count
์ฟผ๋ฆฌ๊ฐ ๋๊ฐ๋๋ฐ, ํ์ฌ๋ ์๋ ๋ ์ํฉ์ ๋ํด์๋ ์ฟผ๋ฆฌ๊ฐ ๋๊ฐ์ง ์๊ฒ ๋ฉ๋๋ค!count
์ฟผ๋ฆฌ ๋์offset()
ํฌ๊ธฐ์ ์กฐํ๋ ์ธํด ๊ณต๊ณ ์ฌ์ด์ฆ๋ฅผ ๋ํด์ ๊ณ์ฐํจ๐ Reference
[Querydsl] Pagination ์ฑ๋ฅ ๊ฐ์ part1.PageableExecutionUtils