Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[๐Ÿ”€ merge] [2์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (5) #146

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

JungYoonShin
Copy link
Member

@JungYoonShin JungYoonShin commented Sep 25, 2024

๐Ÿ“„ Work Description

๐Ÿ’ฌ To Reviewers

[2์ฐจ ์Šคํ”„๋ฆฐํŠธ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ์„ ๋ฐฐํฌํ•˜๊ธฐ ์ „, ํ…Œ์ŠคํŠธ๋ฅผ ํ•˜๊ธฐ ์œ„ํ•ด ์Šคํ…Œ์ด์ง• ์„œ๋ฒ„๋กœ ์ฝ”๋“œ๋ฅผ ๋จธ์ง€ํ•˜๋Š” ์ž‘์—…์„ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

jsoonworld and others added 6 commits September 22, 2024 23:06
- ํšŒ์›๊ฐ€์ž… ์‹คํŒจ ์‹œ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ 401์—์„œ 400์œผ๋กœ ๋ณ€๊ฒฝ
- ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €์ผ ๊ฒฝ์šฐ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ 401์—์„œ 409๋กœ ๋ณ€๊ฒฝ
- ์ž˜๋ชป๋œ ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ์‚ฌ์šฉ ์‹œ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ๋ฅผ INVALID_USER์—์„œ FAILED_TOKEN_REISSUE๋กœ ์ˆ˜์ •
[๐Ÿ”จfix] ํšŒ์›๊ฐ€์ž… ๊ด€๋ จ ์ƒํƒœ ์ฝ”๋“œ ์ˆ˜์ • ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ณ€๊ฒฝ
- OneToMany์‹œ์— fetchJoin()์„ ์‚ฌ์šฉํ•จ์œผ๋กœ์จ ๋ฐœ์ƒํ•˜๋Š” ๋ฐ์ดํ„ฐ ์ค‘๋ณต ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค.
- ๊ธฐ์กด PageIml ์‚ฌ์šฉํ•˜๋˜ ๊ฒƒ์—์„œ PageableExecutionUtils.getPage()๋ฅผ ์‚ฌ์šฉํ•จ์œผ๋กœ์จ ์„ฑ๋Šฅ ์ตœ์ ํ™”๋ฅผ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
[๐Ÿ”จ fix/#140] ๊ฒ€์ƒ‰ํ™”๋ฉด totalPages, totalCount ๋ฐ์ดํ„ฐ ๋ถ€์ •ํ™•ํ•œ ์˜ค๋ฅ˜ ์ˆ˜์ • ๋ฐ count ์ฟผ๋ฆฌ ์„ฑ๋Šฅ ๊ฐœ์„ 
@JungYoonShin JungYoonShin self-assigned this Sep 25, 2024
@JungYoonShin JungYoonShin added the ๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ label Sep 25, 2024
@JungYoonShin JungYoonShin merged commit 025a6cb into staging Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants