Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[๐Ÿ”จfix] ํšŒ์›๊ฐ€์ž… ๊ด€๋ จ ์ƒํƒœ ์ฝ”๋“œ ์ˆ˜์ • ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ณ€๊ฒฝ #142

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jsoonworld
Copy link
Contributor

๐Ÿ“„ Work Description

  • ํšŒ์›๊ฐ€์ž… ๊ด€๋ จ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ ๋” ์ ์ ˆํ•˜๊ฒŒ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ํšŒ์›๊ฐ€์ž… ์‹คํŒจ ์‹œ 401 Unauthorized์—์„œ 400 Bad Request๋กœ ๋ณ€๊ฒฝ.
    • ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €์ผ ๊ฒฝ์šฐ 401 Unauthorized์—์„œ 409 Conflict๋กœ ๋ณ€๊ฒฝ.
  • AuthServiceImpl์—์„œ ์ž˜๋ชป๋œ ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ์‚ฌ์šฉ ์‹œ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ๋ฅผ INVALID_USER์—์„œ FAILED_TOKEN_REISSUE๋กœ ์ˆ˜์ •.

โš™๏ธ ISSUE

๐Ÿ’ฌ To Reviewers

  • ํด๋ผ์ด์–ธํŠธ ์‚ฌ์ด๋“œ์—์„œ ํšŒ์›๊ฐ€์ž… ๊ด€๋ จ ์ด์Šˆ๊ฐ€ ์žˆ๋‹ค๊ณ  ํ•ด์„œ ์„œ๋ฒ„ ๋กœ์ง์„ ํ™•์ธํ–ˆ์ง€๋งŒ, ์„œ๋ฒ„ ๋กœ์ง์—๋Š” ๋ฌธ์ œ๊ฐ€ ์—†์—ˆ์Šต๋‹ˆ๋‹ค.
  • ํด๋ผ์ด์–ธํŠธ ๋กœ์ง์„ ํ•จ๊ป˜ ์‚ดํŽด๋ณด๊ณ  ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜์˜€์œผ๋ฉฐ, ๊ทธ ๊ณผ์ •์—์„œ ์ƒํƒœ ์ฝ”๋“œ ์ˆ˜์ • ์š”์ฒญ์ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.
  • ํšŒ์›๊ฐ€์ž… ์‹คํŒจ ๋ฐ ์ค‘๋ณต ์œ ์ € ๊ด€๋ จ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ํ•˜๊ธฐ ์œ„ํ•ด ์ˆ˜์ •ํ–ˆ์œผ๋‹ˆ, ์ฝ”๋“œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ํ™•์ธํ•ด ์ฃผ์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค.
  • ์ƒํƒœ ์ฝ”๋“œ ๋ณ€๊ฒฝ์ด ์„œ๋ฒ„์™€ ํด๋ผ์ด์–ธํŠธ ๊ฐ„ ํ†ต์‹ ์— ๋ฌธ์ œ๊ฐ€ ์—†๋„๋ก ์ถ”๊ฐ€์ ์ธ ๊ฒ€ํ† ๋ฅผ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ”— Reference

- ํšŒ์›๊ฐ€์ž… ์‹คํŒจ ์‹œ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ 401์—์„œ 400์œผ๋กœ ๋ณ€๊ฒฝ
- ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €์ผ ๊ฒฝ์šฐ ์ƒํƒœ ์ฝ”๋“œ๋ฅผ 401์—์„œ 409๋กœ ๋ณ€๊ฒฝ
- ์ž˜๋ชป๋œ ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ์‚ฌ์šฉ ์‹œ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ๋ฅผ INVALID_USER์—์„œ FAILED_TOKEN_REISSUE๋กœ ์ˆ˜์ •
@jsoonworld jsoonworld added ๐Ÿ”จย fix ๋ฒ„๊ทธ, ์˜ค๋ฅ˜ ์ˆ˜์ • ๐ŸฆŠ์žฅ์ˆœ๐ŸฆŠ labels Sep 22, 2024
@jsoonworld jsoonworld self-assigned this Sep 22, 2024
Copy link
Contributor

@junggyo1020 junggyo1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €๋ฅผ 409๋กœ ๋ณด๋‚ด์ค€ ๋ถ€๋ถ„ ์ข‹๋„ค์š”!! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค:)

@jsoonworld jsoonworld merged commit c053bda into develop Sep 23, 2024
1 check passed
@JungYoonShin
Copy link
Member

JungYoonShin commented Sep 23, 2024

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!! ๊ถ๊ธˆํ•œ ์ ์ด 2๊ฐ€์ง€ ์žˆ๋Š”๋ฐ์š”! ์ด์— ๋Œ€ํ•œ ์žฅ์ˆœ๋‹˜์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค :)

  1. ์ €ํฌ ํšŒ์›๊ฐ€์ž…์‹œ ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €์— ๋Œ€ํ•ด ์˜ˆ์™ธ์ฒ˜๋ฆฌ๋ฅผ ํ•˜๋Š” ๋กœ์ง์ด ์žˆ๋‚˜์š”?! (๋‹จ์ˆœ ๊ถ๊ธˆํ•ด์„œใ…Žใ…Ž)
  • ํšŒ์›๊ฐ€์ž… ์‹คํŒจ ์‹œ 401 Unauthorized์—์„œ 400 Bad Request๋กœ ๋ณ€๊ฒฝ.
  • ์ด๋ฏธ ์กด์žฌํ•˜๋Š” ์œ ์ €์ผ ๊ฒฝ์šฐ 401 Unauthorized์—์„œ 409 Conflict๋กœ ๋ณ€๊ฒฝ.

โœš ์ถ”๊ฐ€๋กœ ๊ฐœ์ธ์ ์ธ ์˜๊ฒฌ์ด์ง€๋งŒ, ํšŒ์›๊ฐ€์ž…์— ์‹คํŒจํ•˜์˜€์Šต๋‹ˆ๋‹ค๋ผ๋Š” ์˜ˆ์™ธ์ฒ˜๋ฆฌ๊ฐ€ ์กฐ๊ธˆ ์ถ”์ƒ์ ์ด๋ผ๋Š” ์ƒ๊ฐ์ด ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค!

ํšŒ์›๊ฐ€์ž…์˜ ์‹คํŒจ ์ด์œ ๊ฐ€ ๋‹ค์–‘ํ•˜๋‹ค๊ณ  ์ƒ๊ฐํ•˜๋Š”๋ฐ(ex. ์œ ํšจํ•˜์ง€์•Š์€ authId, ์นด์นด์˜ค์ธก์œผ๋กœ ๋ถ€ํ„ฐ ์‚ฌ์šฉ์ž ์ •๋ณด ์กฐํšŒ์—์„œ ๋ฐœ์ƒํ•œ ์˜ค๋ฅ˜ ๋“ฑ๋“ฑ), ์ด๋Ÿฐ์‹์œผ๋กœ ๊ตฌ์ฒด์ ์ธ ์ƒํ™ฉ์— ๋งž๊ฒŒ ์—๋Ÿฌ์ฝ”๋“œ๋ฅผ ๊ตฌ๋ถ„ํ•˜๋ฉด ํด๋ผ ๋ฐ ์„œ๋ฒ„์ธก์—์„œ๋„ ์—๋Ÿฌ๋Œ€์‘ํ•˜๊ธฐ์— ์กฐ๊ธˆ ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!


  1. ErroMessage์—์„œ FAILED_WITHDRAW(404, "๊ณ„์ • ํƒˆํ‡ด์— ์‹คํŒจํ•˜์˜€์Šต๋‹ˆ๋‹ค"),๋กœ ๊ด€๋ฆฌํ•˜๊ณ  ๊ณ„์‹œ๋˜๋ฐ, 404๋กœ ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?!

@jsoonworld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ”จย fix ๋ฒ„๊ทธ, ์˜ค๋ฅ˜ ์ˆ˜์ • ๐ŸฆŠ์žฅ์ˆœ๐ŸฆŠ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants