-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builtin boilerplate tests from PR #3866 #4236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍, just make sure to use verifyProperty
(or verifyPrimordialProperty
if this lands after #4234)
test/built-ins/AsyncDisposableStack/prototype/Symbol.asyncDispose.js
Outdated
Show resolved
Hide resolved
test/built-ins/AsyncDisposableStack/prototype/disposed/getter.js
Outdated
Show resolved
Hide resolved
assert.sameValue(DisposableStack.prototype[Symbol.dispose], DisposableStack.prototype.dispose); | ||
verifyNotEnumerable(DisposableStack.prototype, Symbol.dispose); | ||
verifyWritable(DisposableStack.prototype, Symbol.dispose); | ||
verifyConfigurable(DisposableStack.prototype, Symbol.dispose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above, use verifyProperty
verifyNotEnumerable(DisposableStack.prototype, 'disposed'); | ||
verifyConfigurable(DisposableStack.prototype, 'disposed'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above, use verifyProperty
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.
Co-authored-by: Philip Chimento <[email protected]>
7696475
to
8864659
Compare
This PR splits some of the boilerplate tests from PR #3866 to make reviewing all those files a little easier.
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.