Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
ioannad committed Sep 23, 2024
1 parent 2e12028 commit 7696475
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
8 changes: 5 additions & 3 deletions test/built-ins/DisposableStack/prototype/Symbol.dispose.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ features: [explicit-resource-management]
---*/

assert.sameValue(DisposableStack.prototype[Symbol.dispose], DisposableStack.prototype.dispose);
verifyNotEnumerable(DisposableStack.prototype, Symbol.dispose);
verifyWritable(DisposableStack.prototype, Symbol.dispose);
verifyConfigurable(DisposableStack.prototype, Symbol.dispose);
verifyProperty(DisposableStack.prototype, Symbol.dispose, {
enumerable: false;
writable: true;
configurable: true;
});
6 changes: 4 additions & 2 deletions test/built-ins/DisposableStack/prototype/disposed/getter.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,7 @@ assert.sameValue(
'typeof descriptor.set is undefined'
);

verifyNotEnumerable(DisposableStack.prototype, 'disposed');
verifyConfigurable(DisposableStack.prototype, 'disposed');
verifyProperty(DisposableStack.prototype, 'disposed', {
enumerable: false;
configurable: true;
});

0 comments on commit 7696475

Please sign in to comment.