Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the Explicit Resource Management proposal #3866

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add tests for the Explicit Resource Management proposal #3866

wants to merge 3 commits into from
+11,865 −1

Conversation

rbuckton
Copy link
Contributor

This adds tests for the Explicit Resource Management proposal based on the spec text at https://tc39.es/proposal-explicit-resource-management as well as several pending pull requests in the proposal repo.

@ptomato
Copy link
Contributor

ptomato commented Aug 9, 2023

While waiting for a review ... seems like the CI is failing due to invalid front matter in test/language/statements/await-using/Symbol.asyncDispose-getter.js, mind taking a look? Please also check the linter output.

@ljharb
Copy link
Member

ljharb commented Feb 28, 2024

@rbuckton if the PRs are landed, and this is ready for review, please rebase it and mark it as such?

ioannad added a commit to ioannad/test262 that referenced this pull request Jul 26, 2024
@ioannad
Adds property descriptor tests for explicit resource management objects
1cd8e40 
These are all the prop-desc.js tests from PR tc39#3866 to make reviewing easier.
ioannad added a commit to ioannad/test262 that referenced this pull request Jul 26, 2024
@ioannad
Adds .name property descriptor tests for explicit resource management
535c48a 
These are all the name.js tests from PR tc39#3866 to make reviewing easier.
ioannad added a commit to ioannad/test262 that referenced this pull request Jul 26, 2024
@ioannad
Adds .length property descriptor tests for explicit resource management
b3539e5 
These are all the length.js tests from PR tc39#3866 to make reviewing easier.
ioannad added a commit to ioannad/test262 that referenced this pull request Jul 26, 2024
@ioannad
Adds is/not-a-constructor.js tests from tc39#3866
41720df 
to make reviewing easier.
@ioannad ioannad mentioned this pull request Jul 26, 2024
Merged
ioannad pushed a commit to ioannad/test262 that referenced this pull request Jul 29, 2024
@rbuckton @ioannad
Adds property descriptor tests for explicit resource management objects
a90e208 
These are all the prop-desc.js tests from @rbuckton's PR tc39#3866 to make reviewing easier.
ioannad pushed a commit to ioannad/test262 that referenced this pull request Jul 29, 2024
@rbuckton @ioannad
Adds .name property descriptor tests for explicit resource management
f576173 
These are all the name.js tests from @rbuckton's PR tc39#3866 to make reviewing easier.
ioannad pushed a commit to ioannad/test262 that referenced this pull request Jul 29, 2024
@rbuckton @ioannad
Adds .length property descriptor tests for explicit resource management
f08e98f 
These are all the length.js tests from @rbuckton's PR tc39#3866 to make reviewing easier.
ioannad pushed a commit to ioannad/test262 that referenced this pull request Jul 29, 2024
@rbuckton @ioannad
Adds [is/not]-a-constructor.js tests from @rbuckton's PR tc39#3866
b84f3c0 
to make reviewing easier.
ptomato pushed a commit that referenced this pull request Jul 29, 2024
@rbuckton @ptomato
Adds property descriptor tests for explicit resource management objects
3a615a0 
These are all the prop-desc.js tests from @rbuckton's PR #3866 to make reviewing easier.
ptomato pushed a commit that referenced this pull request Jul 29, 2024
@rbuckton @ptomato
Adds .name property descriptor tests for explicit resource management
5965721 
These are all the name.js tests from @rbuckton's PR #3866 to make reviewing easier.
ptomato pushed a commit that referenced this pull request Jul 29, 2024
@rbuckton @ptomato
Adds .length property descriptor tests for explicit resource management
c916d81 
These are all the length.js tests from @rbuckton's PR #3866 to make reviewing easier.
ptomato pushed a commit that referenced this pull request Jul 29, 2024
@rbuckton @ptomato
Adds [is/not]-a-constructor.js tests from @rbuckton's PR #3866
cb8324f 
to make reviewing easier.
@debadree25
Copy link

Hello!!

First of all thank you so much for your work on the proposal and these tests! I noticed there there are efforts to split parts of the pr and land them, i am working on the spider monkey implementation and i frequently find myself referring to this pr to write my tests! so i would be very happy to help landing this in parts if that would an acceptable thing to do! and if so where from should i start and any specific way in which i should break out tests?

ioannad pushed a commit to ioannad/test262 that referenced this pull request Sep 18, 2024
@rbuckton @ioannad
Function branding boilerplate tests from PR tc39#3866
0c14d4a
@ioannad ioannad mentioned this pull request Sep 18, 2024
Merged
ptomato pushed a commit to ioannad/test262 that referenced this pull request Sep 20, 2024
@rbuckton @ptomato
Function branding boilerplate tests from PR tc39#3866
20b03a5
ptomato pushed a commit that referenced this pull request Sep 20, 2024
@rbuckton @ptomato
Function branding boilerplate tests from PR #3866
dc7a22d
ioannad pushed a commit to ioannad/test262 that referenced this pull request Sep 23, 2024
@rbuckton @ioannad
Builtin boilerplate tests from PR tc39#3866
90f77cf 
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.
@ioannad ioannad mentioned this pull request Sep 23, 2024
Merged
@ioannad
Copy link
Contributor

ioannad commented Sep 23, 2024 •
edited
Loading

Hello!!

First of all thank you so much for your work on the proposal and these tests! I noticed there there are efforts to split parts of the pr and land them, i am working on the spider monkey implementation and i frequently find myself referring to this pr to write my tests! so i would be very happy to help landing this in parts if that would an acceptable thing to do! and if so where from should i start and any specific way in which i should break out tests?

@debadree25 thank you! I will stop creating PRs with files from here, so you can take over. So do feel free to make PRs which add tests from here in any kind of grouping you think may ease review. Just please commit the tests with their original author using git commit --author='Ron Buckton <[email protected]>.

Thank you!

@debadree25
Copy link

Thank you so much @ioannad will to get to work on this as soon as i can!

Ms2ger pushed a commit to ioannad/test262 that referenced this pull request Sep 24, 2024
@rbuckton @Ms2ger
Builtin boilerplate tests from PR tc39#3866
cce8f94 
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.
Ms2ger pushed a commit that referenced this pull request Sep 24, 2024
@ioannad @rbuckton @ptomato
Builtin boilerplate tests from PR #3866 (#4236)
c63d53a 
Includes some proto-from-ctor-realm.js tests that look like standard tests for prototypes.

Co-authored-by: Ron Buckton <[email protected]>
Co-authored-by: Philip Chimento <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbuckton @ptomato @ljharb @debadree25 @ioannad