Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2426): support mustache template on generate::config #2657

Merged
merged 17 commits into from
Aug 30, 2024
Merged

feat(2426): support mustache template on generate::config #2657

merged 17 commits into from
Aug 30, 2024

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2646
/claim 2646

@algora-pbc algora-pbc bot mentioned this pull request Aug 11, 2024
Closed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 11, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (5dab91b) to head (721d372).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/generator/generator.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
- Coverage   86.88%   86.80%   -0.09%     
==========================================
  Files         255      254       -1     
  Lines       25158    25026     -132     
==========================================
- Hits        21858    21723     -135     
- Misses       3300     3303       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title chore: support mustache template on generate::config feat(2426): support mustache template on generate::config Aug 13, 2024
@tusharmath tusharmath marked this pull request as draft August 13, 2024 07:13
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Aug 17, 2024
@ssddOnTop ssddOnTop mentioned this pull request Aug 18, 2024
Closed
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 22, 2024
@ssddOnTop ssddOnTop mentioned this pull request Aug 26, 2024
Merged
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Aug 28, 2024
@ssddOnTop ssddOnTop marked this pull request as ready for review August 29, 2024 13:52
@tusharmath tusharmath enabled auto-merge (squash) August 30, 2024 08:38
@tusharmath tusharmath merged commit 075e1f8 into main Aug 30, 2024
35 of 36 checks passed
@tusharmath tusharmath deleted the chore/gen-cfg-mustache branch August 30, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mustache templates in all string fields generate::config
2 participants
@ssddOnTop @tusharmath