chore: convert cli tests to md #2735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
+ Coverage 86.46% 86.82% +0.35%
==========================================
Files 255 255
Lines 24963 24963
==========================================
+ Hits 21584 21673 +89
+ Misses 3379 3290 -89 ☔ View full report in Codecov by Sentry. |
tusharmath
reviewed
Aug 26, 2024
tusharmath
reviewed
Aug 26, 2024
| @@ -25,6 +25,8 @@ pub struct Config<Status = UnResolved> { | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub preset: Option<PresetConfig>, | |||
| pub schema: Schema, | |||
| #[serde(default, skip_serializing_if = "TemplateString::is_empty")] | |||
There was a problem hiding this comment.
existing tests don't even work rn.. the config in tests is either outdated or we need to add the default tag on secret
|
closing in favor of #2755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #2646
Description: This PR converts cli tests to md based tests. This will help to set predefined instructions and add mocks. (for example, setting Env variables).
(ext of #2657)