new version ready, uv_queue_work works on PHP 8+

- Linux tests pass as is, Windows after callback not executed and segfaults still. In reference to issues: amphp#83, amphp#93, amphp#64
symplely · Apr 4, 2023 · 5f32796 · 5f32796
1 parent a059a27
commit 5f32796
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/Ubuntu.yml b/.github/workflows/Ubuntu.yml
@@ -1,7 +1,10 @@
 name: Ubuntu
 
 on:
+  push:
+    branches: [ master ]
   pull_request:
+    branches: [ master ]
   workflow_dispatch:
 
 jobs:

diff --git a/tests/800-uv_queue_work.phpt b/tests/800-uv_queue_work.phpt
@@ -5,8 +5,8 @@ Check for uv_queue_work
 ob_start();
 phpinfo();
 $data = ob_get_clean();
-if (!preg_match("/Thread Safety.+?enabled/", $data)) {
-  echo "skip not implemented for PHP 8+, Windows after callback not called, and shows segfault";
+if (!preg_match("/Thread Safety.+?enabled/", $data) || '\\' === DIRECTORY_SEPARATOR) {
+  echo "skip Windows after callback not called, and shows segfault, Linux no issues";
 }
 --FILE--
 <?php