Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5.9 toolchain & macOS Sonoma beta #402

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Swift 5.9 toolchain & macOS Sonoma beta #402

merged 4 commits into from
Sep 30, 2023

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Aug 6, 2023

This release adds SwiftWasm 5.9 toolchain support, which includes usability with macOS Sonoma beta.

- checking Swift compiler path: /Users/furby/.carton/sdk/wasm-5.9-SNAPSHOT-2023-08-01-a/usr/bin/swift
- checking Swift compiler path: /Users/furby/.swiftenv/versions/wasm-5.9-SNAPSHOT-2023-08-01-a/usr/bin/swift
- checking Swift compiler path: /Users/furby/Library/Developer/Toolchains/swift-wasm-5.9-SNAPSHOT-2023-08-01-a.xctoolchain/usr/bin/swift
Inferring basic settings...
- swift executable: /Users/furby/Library/Developer/Toolchains/swift-wasm-5.9-SNAPSHOT-2023-08-01-a.xctoolchain/usr/bin/swift
SwiftWasm Swift version 5.9-dev (LLVM 8250a14f5d3ef6a, Swift 57acd8f2a758d01)
Target: arm64-apple-darwin23.0.0

Parsing package manifest:
[debug]: evaluating manifest for 'cosmicportal' v. unknown- development binary to serve: /Users/furby/dev/Atmos/CosmicPortal/.build/wasm32-unknown-wasi/debug/CosmicPortal.wasm

Building the project before spinning up a server...
Compiling...
/Users/furby/Library/Developer/Toolchains/swift-wasm-5.9-SNAPSHOT-2023-08-01-a.xctoolchain/usr/bin/swift build -c debug --product CosmicPortal --triple wasm32-unknown-wasi -Xswiftc -Xclang-linker -Xswiftc -mexec-model=reactor -Xlinker --export=main -Xlinker /Users/furby/.carton/static/so_sanitizer.wasm -Xlinker --stack-first[0/1] Planning build
Building for debugging...
[0/1] Linking CosmicPortal.wasm
Build complete! (3.97s)


`swift` process finished successfully
`swift build` completed in 4.22 seconds
Binary transformation for Safari compatibility completed in 0.34 seconds

@furby-tm furby-tm changed the title Support for Swift 5.9 toolchain & macOS Sonoma beta Swift 5.9 toolchain & macOS Sonoma beta Aug 6, 2023
@STREGA STREGA self-requested a review August 15, 2023 21:10
Package.swift Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@STREGA STREGA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking to the time to make these changes and create a pull-request.
It's appreciated!

I've got had few small changes needed when you get a chance.

Some of the changes involve using the Swift 5.9 release toolchain, even though it doesn't exist yet. The reason for that is because I want to avoid using snapshots for a major release of Carton. So I'm going to hold off merging this until 5.9 is released which should happen with Xcode 15's release in early September which isn't very far away.

@STREGA STREGA added the enhancement New feature or request label Aug 15, 2023
@STREGA STREGA self-assigned this Aug 15, 2023
@STREGA STREGA mentioned this pull request Aug 15, 2023
1 task
@furby-tm
Copy link
Contributor Author

furby-tm commented Aug 15, 2023

Thanks for taking to the time to make these changes and create a pull-request. It's appreciated!

I've got had few small changes needed when you get a chance.

Some of the changes involve using the Swift 5.9 release toolchain, even though it doesn't exist yet. The reason for that is because I want to avoid using snapshots for a major release of Carton. So I'm going to hold off merging this until 5.9 is released which should happen with Xcode 15's release in early September which isn't very far away.

I have made each of the changes you had mentioned, thank you!

NOTE: For anyone that may be using this branch in the interim before the Swift 5.9 toolchain is released, this breaks carton on the 5.9 toolchain until it's official release, if you depend on carton working on the pre-release Swift 5.9 Toolchain, please instead use wasm-DEVELOPMENT-SNAPSHOT-2023-08-07-a, the latest development snapshot in the meantime.

@STREGA
Copy link
Member

STREGA commented Aug 15, 2023

Awesome! Don't forgot to use Swift 5.9 RELEASE in the Dockerfile as well.

@furby-tm
Copy link
Contributor Author

furby-tm commented Aug 15, 2023

Good catch! I have also bumped the docker base image pending 5.9's release, as well.

Copy link
Member

@STREGA STREGA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Deferring merge until Swift 5.9 is released. Checks are expected to fail until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants