-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low Priority: For Carton on Swift 5.9 Toolchain #539
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furby-tm
changed the title
Make compatible with Swift 5.9 Toolkit, fix deprecations, update packages.
Support Swift 5.9 Toolkit/macOS beta, fix deprecations, update packages.
Aug 5, 2023
furby-tm
changed the title
Support Swift 5.9 Toolkit/macOS beta, fix deprecations, update packages.
Low Priority: Swift 5.9/macOS & iOS version compatibility, fix deprecations, update packages.
Aug 5, 2023
furby-tm
changed the title
Low Priority: Swift 5.9/macOS & iOS version compatibility, fix deprecations, update packages.
Low Priority: For Carton on Swift 5.9 Toolchain
Aug 5, 2023
Add tap, lonPress and Drag gestures.
The carton changes to support the Swift 5.9 toolchain have been approved here. Looks like we should now bump the Swift tools version to 5.7 within Tokamak's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are optional, very low priority, and are really meant to go in tandem with the below release of carton (if approved), but it would be nice to have some updated packages to sync with carton; and some better compatibility when targeting the Swift 5.9 toolchain as well as later versions of macOS/iOS.
The easiest way to test this since carton doesn't appear to support pre-release versions of Swift is to use this release of carton in the meantime.
If I fix-up the template for tokamak in the above carton release, would a PR for carton possibly be approved for a pre-release version? I do not see any prior pre-release versions of carton, and was not sure if this is something the carton developers would like to support.
Note: TimelineView has been temporarily disabled in the demo due to:
The above error is strange, have you guys been able to compile the demo as-is on current toolchain versions?
Everything else appears to be in tact.