Enhancements to Macro Examples: Unit Tests and Code Organization #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thanks a lot @Matejkob, this makes the examples a lot easier to understand. I’ve got a couple of suggestions, mostly to fix formatting, inline.
@DougGregor I would appreciate if you could take a look at the new test cases to make sure they are actually testing the intended behavior of the macros.
Examples/Sources/MacroExamples/Implementation/Expression/FontLiteralMacro.swift
Show resolved
Hide resolved
Examples/Tests/MacroExamples/Implementation/ComplexMacros/DictionaryIndirectionMacroTests.swift
Outdated
Show resolved
Hide resolved
Examples/Tests/MacroExamples/Implementation/ComplexMacros/DictionaryIndirectionMacroTests.swift
Outdated
Show resolved
Hide resolved
Examples/Tests/MacroExamples/Implementation/Member/CustomCodableTests.swift
Outdated
Show resolved
Hide resolved
Examples/Tests/MacroExamples/Implementation/Member/MetaEnumMacroTests.swift
Outdated
Show resolved
Hide resolved
Examples/Tests/MacroExamples/Implementation/Peer/AddAsyncMacroTests.swift
Outdated
Show resolved
Hide resolved
kimdv
reviewed
Sep 7, 2023
Examples/Sources/MacroExamples/Implementation/Expression/FontLiteralMacro.swift
Show resolved
Hide resolved
Matejkob
force-pushed
the
macro-examples-unit-tests
branch
from
4cfedda
to
39032ab
Compare
13 tasks
DougGregor
approved these changes
Sep 18, 2023
Examples/Sources/MacroExamples/Implementation/Expression/FontLiteralMacro.swift
Show resolved
Hide resolved
ahoppen
approved these changes
Sep 18, 2023
|
@swift-ci Please test |
This commit restructures the macro implementation examples into type-specific directories, streamlining the search process for newcomers and enhancing overall accessibility
This commit extends the categorization to macro interfaces
auto-merge was automatically disabled
September 19, 2023 18:45
Head branch was pushed to by a user without write access
Matejkob
force-pushed
the
macro-examples-unit-tests
branch
from
39032ab
to
919ae85
Compare
|
@swift-ci Please test |
|
I believe something went wrong with Swift Test Windows |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a set of improvements to the macro examples, including the addition of unit tests, the categorization of macro interfaces, and the restructuring of the directory to make it more accessible and navigable.
Changes:
MARKcomments. This standardization not only cleans up the code but also makes it easier to find your way around.