Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate the ExamplePlugin target into the MacroExamples target #2165

Closed
Matejkob opened this issue Sep 7, 2023 · 3 comments · Fixed by #2222
Closed

Incorporate the ExamplePlugin target into the MacroExamples target #2165

Matejkob opened this issue Sep 7, 2023 · 3 comments · Fixed by #2222
Assignees
@Matejkob

Comments

@Matejkob
Copy link
Contributor

Matejkob commented Sep 7, 2023 •
edited
Loading 

          I'm wondering if we still need the [`ExamplePlugin` target in the `Examples` package](https://github.com/apple/swift-syntax/tree/main/Examples/Sources/ExamplePlugin) - was it mainly used for lit tests, and is it now a bit redundant with `MacroExamples`?

Originally posted by @Matejkob in #2160 (review)

Since the last lit test has been removed we don't need a separated ExamplePlugin target so we can merge macros into MacroExamples.
@Matejkob
Copy link
Contributor Author

Matejkob commented Sep 7, 2023

I'm on it 😇

@ahoppen
Copy link
Contributor

ahoppen commented Sep 7, 2023

Tracked in Apple’s issue tracker as rdar://115120727

@Matejkob
Copy link
Contributor Author

Blocked by #2163

@Matejkob Matejkob mentioned this issue Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matejkob Matejkob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge macro examples from ExamplePlugin target into MacroExamples Matejkob/swift-syntax
2 participants
@ahoppen @Matejkob