Add .staticLibrary support for binary targets
#8639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
FranzBusch
force-pushed
the
fb-static-library-binary-target
branch
from
9896b6f to
709c982
Compare
|
@swift-ci test |
FranzBusch
force-pushed
the
fb-static-library-binary-target
branch
from
709c982 to
625b9dd
Compare
|
@swift-ci test |
FranzBusch
force-pushed
the
fb-static-library-binary-target
branch
from
625b9dd to
b2c0c24
Compare
|
@swift-ci test |
dschaefer2
reviewed
May 9, 2025
| case xcframework | ||
| case artifactsArchive | ||
| case artifactsArchive([String]) |
There was a problem hiding this comment.
This will require a version update to v8 for the workspace state.
There was a problem hiding this comment.
Good catch. I just pushed a change that should allow us to do this without having to version the JSON format and will in the worst case require a clean build. Do you think that's okay?
There was a problem hiding this comment.
@dschaefer2 addressed this break by introducing a forwards compatibility new case and mapped the old one to it.
|
@swift-ci test |
bkhouri
reviewed
May 9, 2025
Fixtures/BinaryLibraries/Static/Package1/Simple.artifactbundle/info.json
Show resolved
Hide resolved
bkhouri
reviewed
May 9, 2025
FranzBusch
force-pushed
the
fb-static-library-binary-target
branch
from
aa13c69 to
8041c94
Compare
|
@swift-ci test |
|
@swift-ci test windows |
owenv
reviewed
May 13, 2025
FranzBusch
force-pushed
the
fb-static-library-binary-target
branch
from
8041c94 to
b45e400
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/swiftlang/swift-evolution/blob/main/proposals/0482-swiftpm-static-library-binary-target-non-apple-platforms.md