Fix test and review feedback

Author: FranzBusch

Sources/Workspace/Workspace+State.swift

@@ -427,15 +427,16 @@ extension WorkspaceStateStorage {
 
             enum Kind: Codable {
                 case xcframework
-                case artifactsArchive([String])
+                case artifactsArchive
+                case typedArtifactsArchive([String])
                 case unknown
 
                 init(_ underlying: BinaryModule.Kind) {
                     switch underlying {
                     case .xcframework:
                         self = .xcframework
                     case .artifactsArchive(let types):
-                        self = .artifactsArchive(types.map { $0.rawValue })
+                        self = .typedArtifactsArchive(types.map { $0.rawValue })
                     case .unknown:
                         self = .unknown
                     }
@@ -445,7 +446,11 @@ extension WorkspaceStateStorage {
                     switch self {
                     case .xcframework:
                         return .xcframework
-                    case .artifactsArchive(let types):
+                    case .artifactsArchive:
+                        // For backwards compatiblity reasons we assume an empty types array which in the worst case
+                        // results in a need for a clean build but we won't fail decoding the JSON.
+                        return .artifactsArchive(types: [])
+                    case .typedArtifactsArchive(let types):
                         return .artifactsArchive(types: types.compactMap { ArtifactsArchiveMetadata.ArtifactType(rawValue: $0) })
                     case .unknown:
                         return .unknown

Tests/FunctionalTests/StaticBinaryLibrary.swift

@@ -12,22 +12,20 @@
 import DriverSupport
 import PackageModel
 import TSCBasic
-import Testing
+import XCTest
 import _InternalTestSupport
 
-@Suite
-struct StaticBinaryLibraryTests {
-    @Test
-    func staticLibrary() async throws {
+final class StaticBinaryLibraryTests: XCTestCase {
+    func testStaticLibrary() async throws {
+        try XCTSkipOnWindows(because: "https://github.com/swiftlang/swift-package-manager/issues/8657")
+
         try await fixture(name: "BinaryLibraries") { fixturePath in
             let (stdout, stderr) = try await executeSwiftRun(
                 fixturePath.appending("Static").appending("Package1"),
                 "Example",
                 extraArgs: ["--experimental-prune-unused-dependencies"]
             )
-            // We expect no warnings to be produced. Specifically no unused dependency warnings.
-            #expect(!stderr.contains("warning:"))
-            #expect(stdout ==  """
+            XCTAssertEqual(stdout,  """
             42
             42