Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry more flaps calls and classify errors better #3671

Closed
wants to merge 4 commits into from

Commits on Jun 25, 2024

  1. Retry more flaps calls and classify errors better

    Sorry, this is a two part PR:
    1. We're now retrying every flaps call where it seems relevant. I
    noticed in tracing that some builder creations were failing
    unnecessarily
    2. We're now catching more errors. For whatever reason, flaps can return
    "App not found" or "Could not find app" when it has an issue finding an
    app. We're doing string comparisons :vomit: to find both
    billyb2 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    99eebd2 View commit details
    Browse the repository at this point in the history
  2. Reorganize retryFlapsCall

    I realize that I'm not correctliy recording the status codes in the way
    that I wanted. We're now always recording flaps error status codes
    billyb2 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    829e5f4 View commit details
    Browse the repository at this point in the history
  3. Fix linting

    billyb2 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3194dad View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    751fd48 View commit details
    Browse the repository at this point in the history