Retry more flaps calls and classify errors better #3671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, this is a two part PR: 1. We're now retrying every flaps call where it seems relevant. I noticed in tracing that some builder creations were failing unnecessarily 2. We're now catching more errors. For whatever reason, flaps can return "App not found" or "Could not find app" when it has an issue finding an app. We're doing string comparisons :vomit: to find both
I realize that I'm not correctliy recording the status codes in the way that I wanted. We're now always recording flaps error status codes
|
Could the retry code be added to the client code itself? I think it would be more clean. |
yea that's a good idea |
| }) | ||
|
|
||
| if err != nil { | ||
| if strings.Contains(err.Error(), "machine still restarting") { |
There was a problem hiding this comment.
Small neat but switch statements are more readable
|
Closing, superseded by #3785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Sorry, this is a two part PR:
How:
I created a new function that retries flaps errors that are > 500 and < 600. There are likely other errors we can retry (408, for example)
Related to:
Documentation