Report usage of StripeClient #1698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-stripe-client-usage
branch
from
2cf8397 to
e2ece8d
Compare
| @@ -121,6 +121,9 @@ public void setUpStripeMockUsage() { | |||
| httpClientSpy = Mockito.spy(new HttpURLConnectionClient()); | |||
| networkSpy = Mockito.spy(new LiveStripeResponseGetter(null, httpClientSpy)); | |||
| mockClient = new StripeClient(networkSpy); | |||
| // The StripeClient constructor calls .setUsage on networkSpy, let's reset that so | |||
| // in the test cases we can just verify the calls we care about. | |||
| Mockito.reset(networkSpy); | |||
There was a problem hiding this comment.
Should we change our test infra to have 2 spies / separate LiveStripeResponseGetters for APIResource and StripeClient?
There was a problem hiding this comment.
My worry with that, is that we would then need to make copies of all the other helper functions here that use networkSpy and it might be a bad experience when you're writing a test to have to choose between them and select the right one, and I hesitated to make the experience worse in 95% of cases for an edge case that only affects usage-related tests.
I was on the fence though, let me know what you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
StripeClientinX-Stripe-Client-Telemetry. (You can disable telemetry viaStripe.enableTelemetry = false;, see the README.)Details
LiveStripeResponseGettera mutable "usage" that it will set on all requests it creates.StripeClientconstructor to set usage on itsLiveStripeResponseGetterto["stripe_client"].RequestTelemetryto accept usage and set it appropriately onX-Stripe-Client-Telemetry. Had to add a parameter to a public method, so I made a new overload and deprecated the old one. Had to disable a linter rule to do this.Testing
src/test/java/com/stripe/functional/StripeClientTest.java
and src/test/java/com/stripe/functional/LiveStripeResponseGetterTest.java mock at the HttpClient level.