Report usage of stripe_client
#1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-stripe-client-usage
branch
4 times, most recently
from
fca564f to
3e9518d
Compare
richardm-stripe
commented
Jan 16, 2024
richardm-stripe
requested review from
a team and
helenye-stripe
and removed request for
a team
src/test/java/com/stripe/functional/LiveStripeResponseGetterTest.java
Outdated
Show resolved
Hide resolved
richardm-stripe
force-pushed
the
richardm-stripe-client-usage
branch
from
f4fef22 to
f28076b
Compare
richardm-stripe
commented
Jan 16, 2024
pakrym-stripe
requested changes
Jan 17, 2024
pakrym-stripe
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
StripeClientinX-Stripe-Client-Telemetry. (You can disable telemetry viaStripe.enableTelemetry = false;, see the README.)Details
usageon each callsite toStripeResponseGetter.requestfromStripeClient, rather than attempting to wrapLiveStripeResponseGetter.RequestTelemetryto accept usage and set it appropriately onX-Stripe-Client-Telemetry. Had to add a parameter to a public method, so I made a new overload and deprecated the old one. Had to disable a linter rule to do this.