Fix vector assignment with undefined delay #1164
Merged
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assignments with an undefined intra-assignment delay should be treated like assignments with zero delay. For the most part this is implemented correctly, except for assignments to a part of a vector where the offset inside the vector is an immediate value. E.g. ``` reg [1:0] x; integer d = 'x; ... x[0] <= #d 1'b1 ``` Here when loading the delay into the index register flag 4 is updated, but never cleared afterwards. As a result, if the delay is undefined, the vector assignment will be skipped. Fix this by making sure flag 4 is always cleared before the vector assignment instruction. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
force-pushed
the
fix-undefined-delay
branch
from
fdbcb1e
to
1ac2020
Compare
Check that assignments with undefined intra-assignment delay get executed with zero delay. The assignment should not be skipped. Signed-off-by: Lars-Peter Clausen <[email protected]>
larsclausen
force-pushed
the
fix-undefined-delay
branch
from
1ac2020
to
fa83f42
Compare
martinwhitaker
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments with an undefined delay should be treated like assignments with
zero delay. For the most part this is implemented correctly, except for
assignments to a part of a vector where the offset inside the vector is an
immediate value. E.g.
Here when loading the delay into the index register flag 4 is updated, but
never cleared afterwards. As a result, if the delay is undefined, the vector
assignment will be skipped. Fix this by making sure flag 4 is always
cleared before the vector assignment instruction.