-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make better use of ES6 #2
Comments
Sir, can I give it a try and if yes please brief me about this. |
That would be great, Deepak. For each example, edit in Makerchip, make the 3 itemized changes above, and make sure the example still produces the same VIZ without errors in the console.log. Clear? |
You can fork and commit changes (through the github web interface, if you like), then submit a merge request w/ upstream master. |
Sir, can you tell me what is the file location. So, that I can do it with github web interface |
You can do this for all .tlv files that have |
BTW, I was just working with life_sv_viz.tlv, so I cleaned that one up. You might find merge conflicts if you edit that one, so |
Sir, I created a PR. Please check |
Thanks!!! I will check after Christmas.
…On Thu, Dec 24, 2020, 11:51 AM Deepak S ***@***.***> wrote:
Sir, I created a PR. Please check
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWHLEDFPL63PXOXOEWVIM3SWNWQ7ANCNFSM4T6DCZ6Q>
.
|
No Problem sir, BTW Merry Christmas |
Sir, created a PR. Please check |
Thanks!! Merged. There was one ";" that shouldn't have been removed, but I
realized it was inside a comment anyway, and I restored it.
Steve Hoover <https://www.linkedin.com/in/steve-hoover-a44b607/>
774-773-8333
<http://www.redwoodeda.com/>
…On Sun, Dec 27, 2020 at 9:02 PM Deepak S ***@***.***> wrote:
Sir, created a PR. Please check
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWHLEF4VJQU5GB33T4F273SW7RLDANCNFSM4T6DCZ6Q>
.
|
Thanks sir and sorry for the mistake.
On Mon, 28 Dec 2020, 9:30 p.m. Steve Hoover, <[email protected]>
wrote:
… Thanks!! Merged. There was one ";" that shouldn't have been removed, but I
realized it was inside a comment anyway, and I restored it.
Steve Hoover <https://www.linkedin.com/in/steve-hoover-a44b607/>
774-773-8333
<http://www.redwoodeda.com/>
On Sun, Dec 27, 2020 at 9:02 PM Deepak S ***@***.***> wrote:
> Sir, created a PR. Please check
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#2 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ACWHLEF4VJQU5GB33T4F273SW7RLDANCNFSM4T6DCZ6Q
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARSGU4PWXYJI33XSISSMJKDSXCTQHANCNFSM4T6DCZ6Q>
.
|
The JS syntax I was using is a bit obsolete. Some things that could be cleaned up:
;
.function
keyword. E.g.initEach: function () {
becomesinitEach() {
.return {objects: {rect: rect, shadow: shadow}};
becomesreturn {objects: {rect, shadow}}
The text was updated successfully, but these errors were encountered: