Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stan syntax and tags #253

Merged
merged 32 commits into from
Oct 15, 2023
Merged

New stan syntax and tags #253

merged 32 commits into from
Oct 15, 2023

Conversation

MansMeg
Copy link
Collaborator

@MansMeg MansMeg commented Sep 22, 2023

The PR includes:

  • Updated the stan syntax to 2.26
  • Cleaned up the tags structures.
  • All posteriors has been checked to compile and runs

@MansMeg MansMeg changed the title New stan syntax New stan syntax and tags Sep 22, 2023
@paul-buerkner
Copy link
Collaborator

I am afraid I won't have the time for full code checking at the moment. Is there something you would like me to take a look at specificially?

@MansMeg
Copy link
Collaborator Author

MansMeg commented Sep 27, 2023

Sorry for my late reply. I updated all the syntax using the stance compiler and checked that all models works to compile and run so I would just skim through quickly and see if you see anything crazy.

I also polished the tags based on discussion with aki to formalize that a little more. You can see the keywords here:
doc/KEYWORDS.md
That might be good to get extra eyes on.

We have also discussed better ways to assess convergence for reference posteriors (that are less hacky) in:
doc/REFERENCE_POSTERIOR_DEFINITION.md
That might also be good to just look through.

@paul-buerkner
Copy link
Collaborator

I am currently super busy with teaching and grant writing. If you want to merge it this or next week, perhaps already merge without my feedback. Sorry for being so slow with this right now :-(

@MansMeg
Copy link
Collaborator Author

MansMeg commented Oct 12, 2023

No problem @paul-buerkner . Maybe @avehtari could take a quick look if something is missing.

Copy link
Collaborator

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some edits to md files. It would have been better to use canonicalizer with the option that would have changed only the syntax and not make additional white space changes. Now there were too many files with only white space changes and I didn't have time check changes that matter. If the new code did run and the results did not change, I expect no problems.

@MansMeg MansMeg merged commit ae1dce9 into master Oct 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants