Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of "using stan::math::x" and "using stan::x" for non-ambiguous functions #1155

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

rok-cesnovar
Copy link
Member

@rok-cesnovar rok-cesnovar commented Mar 12, 2019

Summary

This is another slam-dunkish PR to cleanup some of the old issues. I am running some performance/tuning tests and have some downtime to go through this easy stuff.

This PR removes the using statements for the following non-ambiguous functions:

stan::math::dot_self;
stan::math::include_summand;
stan::math::inv_logit;
stan::math::value_of;
stan::math::check_consistent_sizes;
stan::math::check_finite;
stan::math::check_not_nan;
stan::math::check_positive;
stan::math::check_less_or_equal;
stan::math::check_nonnegative;
stan::math::dot_product;
stan::math::square;

stan::is_constant_struct;
stan::is_vector;

The remaining using statements in stan/math are either in the Eigen namespace or for the following

functions 
max_size
get
length
is_vector
round
lgamma

Tests

/

Side Effects

/

Checklist

Copy link
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@rok-cesnovar
Copy link
Member Author

I am getting the following error on the Windows jenkins machine. I tried restarting the Always-run tests part 1 but no dice :/

[main] make 17312 fork: child -1 - CreateProcessW failed for 'c:\Rtools\bin\make.exe', errno 30

make: make/compiler_flags:40: fork: Read-only file system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants