Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary using statements from vectorized functions #426

Closed
rayleigh opened this issue Oct 28, 2016 · 2 comments
Closed

Remove unnecessary using statements from vectorized functions #426

rayleigh opened this issue Oct 28, 2016 · 2 comments
Assignees
Milestone

Comments

@rayleigh
Copy link
Contributor

rayleigh commented Oct 28, 2016

Summary:

Some of the functions vectorized in #202 have an unnecessary using stan::math:: statement that can be removed.

Description:

See above.

Reproducible Steps:

Look in the code. If it's including a function defined in stan/math/prim/scal/fun/ and has an using stan::math:: statement, remove the using statement.

Current Output:

The using statement is there.

Expected Output:

The using statement should be removed.

Additional Information:

Provide any additional information here.

Current Version:

v2.12.0

@syclik syclik added this to the v2.13.0 milestone Nov 15, 2016
@syclik syclik modified the milestones: v2.13.0++, v2.13.0 Nov 24, 2016
@syclik syclik modified the milestones: v2.14.0, 2.14.0++ Dec 26, 2016
@bob-carpenter bob-carpenter self-assigned this Apr 3, 2017
@bob-carpenter bob-carpenter modified the milestones: 2.15.0++, 2.14.0++ Apr 3, 2017
@bob-carpenter
Copy link
Contributor

This is a much bigger issue. When you're in a namespace, you don't need the namespace qualification. I'll go through and get rid of all the using statements of the form using stan::math::X; and all the qualifications stan::math::.

@syclik
Copy link
Member

syclik commented Apr 24, 2019

Closing. This was fixed with #1155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants