-
Notifications
You must be signed in to change notification settings - Fork 52
Onboarding Intake(1/3): Intake Runner #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devanshcache
wants to merge
38
commits into
stackitcloud:main
Choose a base branch
from
stackit-intake:onboard-intake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
47b81cc
Resolve conflicts
cd7afd7
added example of intake runner
6cd1576
added datasource for intake runner
d86b63e
Resolve conflicts
dc989ee
Add docs
68b9ee4
Update stackit/internal/services/intake/runner/data_source.go
yago-123 42eeda6
Remove region field
c30eb6a
Add description to custom endpoint
139027a
Adjust fields for resource.go (still missing region)
07ae9aa
Reintroduce region as optional field in data resource
ccab9c7
Adjust resource implementation and implement review comments
70d0890
Reshape resource_acc_test
e9e819b
Remove replace directive during name change & complement test checks
c175acc
docs
3b40d7c
lint
dbdb4f7
Adjust resource_test
af76741
adjust last small tweaks
0a779a8
lint
9feee40
Add missing checks in tests
6804432
Fix remaining test failing in resource_test.go
ded68a1
Adjust destroy function
ecb66fd
Reestablish tf-plugin-docs to newer version and re-generate docs prop…
a7964f6
Address review
4dd0beb
Small adjustment
87f2376
Small adjustment and complete docs
7ff4f54
Rebase
f250771
lint
1c0e2ab
Use new SDK with region removed from hostname
34c0665
Remove computed field from description and labels
f7e9630
Remove region from resource-min.tf test
d13bff8
Move numerical payloads to variables
90146e7
Remove region from resource-min.tf test
97c1743
Replace unnecessary concatenation with sprintf
1ba732a
Add state fields before starting wait handler & retrieve ctx from Set…
3f5ab14
Log response during update
72ccfa3
Reestablish 'Computed: true' for labels until we agree on a solution
e84b991
Use new SDK API hierarchy
6028dd1
Handle empty labels
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "stackit_intake_runner Data Source - stackit" | ||
| subcategory: "" | ||
| description: |- | ||
| Datasource for STACKIT Intake Runner. | ||
| --- | ||
|
|
||
| # stackit_intake_runner (Data Source) | ||
|
|
||
| Datasource for STACKIT Intake Runner. | ||
|
|
||
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| data "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| runner_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| } | ||
| ``` | ||
|
|
||
| <!-- schema generated by tfplugindocs --> | ||
| ## Schema | ||
|
|
||
| ### Required | ||
|
|
||
| - `project_id` (String) STACKIT Project ID to which the runner is associated. | ||
| - `runner_id` (String) The runner ID. | ||
|
|
||
| ### Optional | ||
|
|
||
| - `region` (String) The resource region. If not defined, the provider region is used. | ||
|
|
||
| ### Read-Only | ||
|
|
||
| - `description` (String) The description of the runner. | ||
| - `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`region`,`runner_id`". | ||
| - `labels` (Map of String) User-defined labels. | ||
| - `max_message_size_kib` (Number) The maximum message size in KiB. | ||
| - `max_messages_per_hour` (Number) The maximum number of messages per hour. | ||
| - `name` (String) The name of the runner. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "stackit_intake_runner Resource - stackit" | ||
rubenhoenle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| subcategory: "" | ||
| description: |- | ||
| Manages STACKIT Intake Runner. | ||
| --- | ||
|
|
||
| # stackit_intake_runner (Resource) | ||
|
|
||
| Manages STACKIT Intake Runner. | ||
|
|
||
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| resource "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| name = "example-runner" | ||
| region = "eu01" | ||
| description = "An example runner for STACKIT Intake" | ||
| max_message_size_kib = 1024 | ||
| max_messages_per_hour = 1000 | ||
| labels = { | ||
| "env" = "development" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| <!-- schema generated by tfplugindocs --> | ||
| ## Schema | ||
|
|
||
| ### Required | ||
|
|
||
| - `max_message_size_kib` (Number) The maximum message size in KiB. | ||
| - `max_messages_per_hour` (Number) The maximum number of messages per hour. | ||
| - `name` (String) The name of the runner. | ||
| - `project_id` (String) STACKIT Project ID to which the runner is associated. | ||
|
|
||
| ### Optional | ||
|
|
||
| - `description` (String) The description of the runner. | ||
| - `labels` (Map of String) User-defined labels. | ||
| - `region` (String) The resource region. If not defined, the provider region is used. | ||
|
|
||
| ### Read-Only | ||
|
|
||
| - `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`region`,`runner_id`". | ||
| - `runner_id` (String) The runner ID. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| data "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| runner_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| resource "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| name = "example-runner" | ||
| region = "eu01" | ||
| description = "An example runner for STACKIT Intake" | ||
| max_message_size_kib = 1024 | ||
| max_messages_per_hour = 1000 | ||
| labels = { | ||
| "env" = "development" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example still missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done