Onboarding Intake(1/3): Intake Runner by devanshcache · Pull Request #1086 · stackitcloud/terraform-provider-stackit

devanshcache · 2025-12-08T08:08:19Z

Description

This PR onboards the new STACKIT Intake (ticket) service into the Terraform provider.

Intake is composed of three components:

Intake Runners: dedicated, isolated runtime data ingestion environment
Intake: a specific data stream or topic within an Intake Runner
Intake Users: provides secure access credentials for your applications to connect to your Intake

This PR contains the Intake Runners part only to make a quicker and less overwhelming review.

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

stackit/internal/services/intake/runner/resource.go

stackit/internal/services/intake/runner/resource_acc_test.go

docs/resources/intake_runner.md

stackit/internal/services/intake/runner/data_source.go

stackit/internal/services/intake/runner/resource.go

stackit/provider.go

stackit/internal/services/intake/runner/data_source.go

stackit/internal/services/intake/runner/resource_acc_test.go

rubenhoenle · 2026-01-26T09:45:30Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

rubenhoenle · 2026-01-26T09:51:21Z

And please check that failing CI pipeline. Maybe run a make lint and a make test before your next update of this PR 😅

yago-123 · 2026-01-26T10:02:51Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

Yes! notice this is still in progress though

yago-123 · 2026-02-23T09:20:33Z

Hi @rubenhoenle👋 all the feedback must have been implemented.

Please notice that I reintroduced the WithRegion(region) during client initialization that you advised against in #1086 (comment). We discussed this internally and we concluded that it's a requirement that we can't change right now. There are some networking restrictions.

I would be very grateful if you could check on whether the region argument is handled correctly because I have some doubts about it.

In order to test the terraform provider binary we used:

terraform {
  required_providers {
    stackit = {
      source = "stackitcloud/stackit"
    }
  }
}

provider "stackit" {
  default_region = "eu01"
}

variable "project_id" {
  type = string
}

resource "stackit_intake_runner" "test_runner" {
  project_id            = var.project_id
  name                  = "test-runner-cli"
  region                = "eu01"
  max_message_size_kib  = 1024
  max_messages_per_hour = 1000
}

# Implicit Region (Uses provider default)
data "stackit_intake_runner" "implicit" {
  project_id = var.project_id
  runner_id  = stackit_intake_runner.test_runner.runner_id
}

data "stackit_intake_runner" "explicit" {
  project_id = var.project_id
  runner_id  = stackit_intake_runner.test_runner.runner_id
  region     = "eu01"
}


output "implicit_read_result" {
  value = "Successfully found runner '${data.stackit_intake_runner.implicit.name}'"
}

output "explicit_read_result" { 
  value = "Successfully found runner '${data.stackit_intake_runner.explicit.name}' in region '${data.stackit_intake_runner.explicit.region}'"
}

rubenhoenle · 2026-02-24T10:07:58Z

I would be very grateful if you could check on whether the region argument is handled correctly because I have some doubts about it.

In fact this collides with

Please notice that I reintroduced the WithRegion(region) during client initialization that you advised against in #1086 (comment). We discussed this internally and we concluded that it's a requirement that we can't change right now. There are some networking restrictions.

Why can't it be changed? Feel free to answer via private chat, we don't have to discuss this here in public.

github-actions · 2026-03-04T03:34:23Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

yago-123 · 2026-03-05T09:22:52Z

Bot keep this open please

github-actions · 2026-03-13T03:38:09Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

yago-123 · 2026-03-19T07:37:26Z

This should be ready for review whenever you have time.

Just pushed the new SDK with the hostname region-free.

CC @rubenhoenle

github-actions · 2026-03-27T04:07:15Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

rubenhoenle · 2026-03-31T08:26:59Z

stackit/internal/services/intake/runner/resource.go

+			"description": schema.StringAttribute{
+				Description: descriptions["description"],
+				Optional:    true,
+				Computed:    true,


Why is this marked as computed? Shouldn't be needed from my perspective.

rubenhoenle · 2026-03-31T08:27:07Z

stackit/internal/services/intake/runner/resource.go

+				Description: descriptions["labels"],
+				ElementType: types.StringType,
+				Optional:    true,
+				Computed:    true,


In this case, if I remove the Computed: true it retrieves the following error:

2026-03-31T17:01:18.527+0200 [ERROR] sdk.helper_resource: Unexpected error: test_name=TestAccIntakeRunnerMin test_terraform_path=/opt/homebrew/bin/terraform test_working_directory=/var/folders/4x/5xl9kvgx4d33r3xjbqd05mw80000gn/T/plugintest2512537327 test_step_number=1 error= | Error running apply: exit status 1 | | Error: Provider produced inconsistent result after apply | | When applying changes to stackit_intake_runner.example, provider | "provider[\"registry.terraform.io/hashicorp/stackit\"]" produced an | unexpected new value: .labels: was null, but now cty.MapValEmpty(cty.String). | | This is a bug in the provider, which should be reported in the provider's own | issue tracker. resource_acc_test.go:62: Step 1/4 error: Error running apply: exit status 1 Error: Provider produced inconsistent result after apply When applying changes to stackit_intake_runner.example, provider "provider[\"registry.terraform.io/hashicorp/stackit\"]" produced an unexpected new value: .labels: was null, but now cty.MapValEmpty(cty.String). This is a bug in the provider, which should be reported in the provider's own issue tracker.

To me this looks like we default to null, but the labels later are retrieved as {} making a difference after the apply (notice this only happens for min test).

An alternative to this would be to modify the mapFields to cover this case...

rubenhoenle · 2026-03-31T08:31:49Z

stackit/internal/services/intake/testdata/resource-min.tf

+
+variable "project_id" {}
+variable "name" {}
+variable "region" {}


Since region is optional, it shouldn't be part of the Min acc test. Only the required fields should be included here.

rubenhoenle · 2026-03-31T08:32:18Z

stackit/internal/services/intake/testdata/resource-min.tf

+  project_id            = var.project_id
+  name                  = var.name
+  region                = var.region
+  max_message_size_kib  = 1024


use a variable here please

rubenhoenle · 2026-03-31T08:32:23Z

stackit/internal/services/intake/testdata/resource-min.tf

+  name                  = var.name
+  region                = var.region
+  max_message_size_kib  = 1024
+  max_messages_per_hour = 1000


rubenhoenle · 2026-03-31T08:32:29Z

stackit/internal/services/intake/testdata/resource-max.tf

+  name                  = var.name
+  region                = var.region
+  description           = "An example runner for Intake"
+  max_message_size_kib  = 1024


rubenhoenle · 2026-03-31T08:32:35Z

stackit/internal/services/intake/testdata/resource-max.tf

+  region                = var.region
+  description           = "An example runner for Intake"
+  max_message_size_kib  = 1024
+  max_messages_per_hour = 1100


rubenhoenle · 2026-03-31T08:33:28Z

stackit/internal/services/intake/utils/utils.go

+	if providerData.IntakeCustomEndpoint != "" {
+		apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.IntakeCustomEndpoint))
+	} else {
+		apiClientConfigOptions = append(apiClientConfigOptions)


This line looks like a leftover to me?

wdym? In the contribution guide is set this way no?

terraform-provider-stackit/.github/docs/contribution-guide/utils/util.go

Line 19 in 2977dba

if providerData.FooCustomEndpoint != "" {

rubenhoenle · 2026-03-31T08:33:55Z

stackit/internal/services/intake/resource_acc_test.go

+var testIntakeRunnerConfigVarsMin = config.Variables{
+	"project_id":            config.StringVariable(testutil.ProjectId),
+	"name":                  config.StringVariable("intake-min-runner"),
+	"region":                config.StringVariable(testutil.Region),


same here, region should not be part of the min test since it's optional

rubenhoenle · 2026-03-31T08:35:16Z

stackit/internal/services/intake/resource_acc_test.go

+			// Data source check: creates config that includes resource and data source
+			{
+				ConfigVariables: testIntakeRunnerConfigVarsMin,
+				Config: fmt.Sprintf(`


Suggested change

Config: fmt.Sprintf(`

fmt.Sprintf(`

%s

%s

data "stackit_intake_runner" "example" {

project_id = %s.project_id

runner_id = %s.runner_id

region = %s.region

}`, testutil.IntakeProviderConfig(), resourceIntakeRunnerMin, intakeRunnerResource, intakeRunnerResource, intakeRunnerResource),

You're already using Sprintf, why use string concatenation here?

rubenhoenle · 2026-03-31T08:36:00Z

stackit/internal/services/intake/resource_acc_test.go

+				data "stackit_intake_runner" "example" {
+					project_id = %s.project_id
+					runner_id  = %s.runner_id
+				}`, testutil.IntakeProviderConfig()+"\n"+resourceIntakeRunnerMax, intakeRunnerResource, intakeRunnerResource),


rubenhoenle · 2026-03-31T08:39:39Z

stackit/internal/services/intake/runner/data_source.go

+	intakeUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/intake/utils"
+	"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate"
+
+	"github.com/stackitcloud/stackit-sdk-go/services/intake"


Suggested change

"github.com/stackitcloud/stackit-sdk-go/services/intake"

intake "github.com/stackitcloud/stackit-sdk-go/services/intake/v1betaapi"

Please use the new SDK structure so we don't introduce new tech-debt here: stackitcloud/stackit-sdk-go#5062

https://github.com/stackitcloud/stackit-sdk-go/blob/52b1898bf973372aa2906175c60cd3a69bf015d3/services/intake/CHANGELOG.md

Applies to the whole implementation. Ping me via DM if you have any further questions 😅

rubenhoenle · 2026-03-31T08:43:53Z

stackit/internal/services/intake/runner/resource.go

+		return
+	}
+
+	utils.SetAndLogStateFields(ctx, &resp.Diagnostics, &resp.State, map[string]any{


Suggested change

utils.SetAndLogStateFields(ctx, &resp.Diagnostics, &resp.State, map[string]any{

ctx = utils.SetAndLogStateFields(ctx, &resp.Diagnostics, &resp.State, map[string]any{

rubenhoenle · 2026-03-31T08:45:41Z

stackit/internal/services/intake/runner/resource.go

+	}
+	ctx = core.LogResponse(ctx)
+
+	// Wait for creation of intake runner


Please make sure to write the id fields to the state before starting the wait handler as instructed in our contribution guide:

terraform-provider-stackit/.github/docs/contribution-guide/resource.go

Lines 211 to 221 in 2977dba

// only in case the create bar API call is asynchronous (Make sure to include *ALL* fields which are part of the

// internal terraform resource id! And please include the comment below in your code):

// Write id attributes to state before polling via the wait handler - just in case anything goes wrong during the wait handler

ctx = utils.SetAndLogStateFields(ctx, &resp.Diagnostics, &resp.State, map[string]interface{}{

"project_id": projectId,

"region": region,

"bar_id": resp.BarId,

})

if resp.Diagnostics.HasError() {

return

}

rubenhoenle · 2026-03-31T08:49:40Z

stackit/internal/services/intake/runner/resource.go

+	}
+
+	// Update runner
+	runnerResp, err := r.client.UpdateIntakeRunner(ctx, projectId, region, runnerId).UpdateIntakeRunnerPayload(*payload).Execute()


After update call please add

ctx = core.LogResponse(ctx)

devanshcache requested a review from a team as a code owner December 8, 2025 08:08

devanshcache changed the title ~~onboarding(1/3): Intake Runner~~ Onboarding Intake(1/3): Intake Runner Dec 8, 2025

rubenhoenle reviewed Dec 12, 2025

View reviewed changes

stackit/internal/services/intake/runner/resource.go Show resolved Hide resolved

marceljk added the ignore-stale label Dec 19, 2025

rubenhoenle removed the ignore-stale label Jan 19, 2026