Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert test changes that broke tests #268

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Revert test changes that broke tests #268

merged 2 commits into from
Aug 3, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 3, 2023

Description

Fixup of #267

spark-k8s op is different here, as it requires the full image name instead of the spec.image struct. So we can't omit the stackableVersion here. We could omit it for the HistoryServer, but that does not really improve things.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 6284ee3 Aug 3, 2023
29 checks passed
@bors bors bot deleted the fix/tests branch August 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants