Skip to content

Commit

Permalink
Revert test changes that broke tests (#268)
Browse files Browse the repository at this point in the history
* Revert test changes that broke tests

* changelog
  • Loading branch information
sbernauer authored Aug 3, 2023
1 parent cb6ac08 commit 6284ee3
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 7 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ All notable changes to this project will be documented in this file.

### Added

- Default stackableVersion to operator version. It is recommended to remove `spec.image.stackableVersion` from your custom resources ([#267]).
- Default stackableVersion to operator version. It is recommended to remove `spec.image.stackableVersion` from your custom resources ([#267], [#268]).

[#267]: https://github.com/stackabletech/spark-k8s-operator/pull/267
[#268]: https://github.com/stackabletech/spark-k8s-operator/pull/268

## [23.7.0] - 2023-07-14

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ metadata:
name: spark-history
spec:
image:
productVersion: "{{ test_scenario['values']['spark'] }}"
productVersion: "{{ test_scenario['values']['spark'].split('-stackable')[0] }}"
stackableVersion: "{{ test_scenario['values']['spark'].split('-stackable')[1] }}"
vectorAggregatorConfigMapName: spark-vector-aggregator-discovery
logFileDirectory:
s3:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ metadata:
name: spark-history
spec:
image:
productVersion: "{{ test_scenario['values']['spark'] }}"
productVersion: "{{ test_scenario['values']['spark'].split('-stackable')[0] }}"
stackableVersion: "{{ test_scenario['values']['spark'].split('-stackable')[1] }}"
logFileDirectory:
s3:
prefix: eventlogs/
Expand Down
3 changes: 2 additions & 1 deletion tests/templates/kuttl/smoke/06-deploy-history-server.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ metadata:
name: spark-history
spec:
image:
productVersion: "{{ test_scenario['values']['spark'] }}"
productVersion: "{{ test_scenario['values']['spark'].split('-stackable')[0] }}"
stackableVersion: "{{ test_scenario['values']['spark'].split('-stackable')[1] }}"
{% if lookup('env', 'VECTOR_AGGREGATOR') %}
vectorAggregatorConfigMapName: vector-aggregator-discovery
{% endif %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ metadata:
name: spark-history
spec:
image:
productVersion: "{{ test_scenario['values']['spark'] }}"
productVersion: "{{ test_scenario['values']['spark'].split('-stackable')[0] }}"
stackableVersion: "{{ test_scenario['values']['spark'].split('-stackable')[1] }}"
{% if lookup('env', 'VECTOR_AGGREGATOR') %}
vectorAggregatorConfigMapName: vector-aggregator-discovery
{% endif %}
Expand Down
4 changes: 2 additions & 2 deletions tests/test-definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ dimensions:
- "false"
- name: spark
values:
- 3.3.0
- 3.4.0
- 3.3.0-stackable0.0.0-dev
- 3.4.0-stackable0.0.0-dev
- name: ny-tlc-report
values:
- 0.1.0
Expand Down

0 comments on commit 6284ee3

Please sign in to comment.