Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add constants for configOverrides file header and footer keys #843

Merged
merged 6 commits into from
Aug 22, 2024
Merged

feat: Add constants for configOverrides file header and footer keys #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9dc0c1
Introduce pub consts for file_header and file_footerw
Maleware Aug 21, 2024
81d54e1
Rename conts
Maleware Aug 21, 2024
bd94a88
Moving vars to more appropriate place
Maleware Aug 21, 2024
665b88b
Better Var names
Maleware Aug 21, 2024
612fbb4
Changelog
Maleware Aug 22, 2024
6fb844c
changelog
sbernauer Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/stackable-operator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

- BREAKING: Replace `lazy_static` with `std::cell::LazyCell` (the original implementation was done in [#827] and reverted in [#835]) ([#840]).

### Added

- `iter::reverse_if` helper ([#838]).
- Add two new constants `CONFIG_OVERRIDE_FILE_HEADER_KEY` and `CONFIG_OVERRIDE_FILE_FOOTER_KEY` ([#843]).

### Changed

- BREAKING: Replace `lazy_static` with `std::cell::LazyCell` (the original implementation was done in [#827] and reverted in [#835]) ([#840]).

[#838]: https://github.com/stackabletech/operator-rs/pull/838
[#843]: https://github.com/stackabletech/operator-rs/pull/843

## [0.73.0] - 2024-08-09

Expand Down
3 changes: 3 additions & 0 deletions crates/stackable-operator/src/product_config_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ use tracing::{debug, error, warn};

use crate::role_utils::{CommonConfiguration, Role};

pub const CONFIG_OVERRIDE_FILE_HEADER_KEY: &str = "EXPERIMENTAL_FILE_HEADER";
pub const CONFIG_OVERRIDE_FILE_FOOTER_KEY: &str = "EXPERIMENTAL_FILE_FOOTER";

type Result<T, E = Error> = std::result::Result<T, E>;

#[derive(Debug, PartialEq, Snafu)]
Expand Down
Loading