Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add constants for configOverrides file header and footer keys #843

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

Maleware
Copy link
Contributor

@Maleware Maleware commented Aug 21, 2024

Description

Introducing

pub const CONFIG_OVERRIDE_FILE_HEADER_KEY
pub const CONFIG_OVERRIDE_FILE_FOOTER_KEY

To be used in Superset and Airflow to have unified key names.

Will be used in stackabletech/superset-operator#530, once merged and released

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry?

@sbernauer
Copy link
Member

Can you please also rename the PR to something like feat: Add constants for configOverrides file header and footer keys

@Maleware Maleware changed the title Feat/pub const file header footer feat: Add constants for configOverrides file header and footer keys Aug 21, 2024
@Maleware
Copy link
Contributor Author

Changelog: 612fbb4

Changed name.

@Maleware Maleware added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 1d56e60 Aug 22, 2024
20 checks passed
@Maleware Maleware deleted the feat/pub_const_file_header_footer branch August 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants