Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Let operators pick stackable version automatically #619

Merged
merged 12 commits into from
Aug 1, 2023
Merged

feat: Let operators pick stackable version automatically #619

merged 12 commits into from
Aug 1, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 6, 2023 •
edited
Loading

Description

Part of stackabletech/issues#404

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title feat: default stackableVersion to operator version feat: Let operators pick stackable version automatically Jul 20, 2023
@sbernauer sbernauer mentioned this pull request Jul 20, 2023
Closed
@sbernauer sbernauer marked this pull request as ready for review July 20, 2023 06:47
@sbernauer sbernauer self-assigned this Jul 20, 2023
maltesander
maltesander approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the changelog comment.

soenkeliebau
soenkeliebau previously requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with @nightkr about this today and she made some very good points in favor of "version operators and images in lockstep" :)

@sbernauer
Copy link
Member Author

It would be great if you could add those to stackabletech/documentation#425

maltesander
maltesander previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing. LGTM otherwise.

src/commons/product_image_selection.rs Outdated Show resolved Hide resolved
maltesander
maltesander approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer disabled auto-merge August 1, 2023 08:39
@sbernauer sbernauer requested review from soenkeliebau and removed request for soenkeliebau August 1, 2023 08:44
@sbernauer sbernauer added this pull request to the merge queue Aug 1, 2023
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Aug 1, 2023
@sbernauer sbernauer added this pull request to the merge queue Aug 1, 2023
@lfrancke lfrancke removed this pull request from the merge queue due to a manual request Aug 1, 2023
@lfrancke lfrancke added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 5f5e8a2 Aug 1, 2023
16 checks passed
@lfrancke lfrancke deleted the feat/stackable-version branch August 1, 2023 09:26
@sbernauer sbernauer mentioned this pull request Aug 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

@soenkeliebau soenkeliebau soenkeliebau left review comments

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @soenkeliebau @maltesander @lfrancke