Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support PR versions in automatic stackableVersion #629

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix: Support PR versions in automatic stackableVersion #629

merged 2 commits into from
Aug 1, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 1, 2023 •
edited
Loading

Description

Fixup of #619

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

maltesander
maltesander approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 7d0d82c Aug 1, 2023
16 checks passed
@sbernauer sbernauer deleted the fix/stackable-version branch August 1, 2023 11:24
@nightkr nightkr mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander