Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow null datetime #149

Merged
merged 3 commits into from
May 21, 2024
Merged

allow null datetime #149

merged 3 commits into from
May 21, 2024

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented May 20, 2024 •
edited
Loading

overtake #116
closes #77

note: To me it seems that the specs says that datetime should be a string or null meaning that even if null it should be provided.

cc @alukach

@vincentsarago vincentsarago requested a review from gadomski May 20, 2024 20:27
gadomski
gadomski reviewed May 20, 2024
View reviewed changes
stac_pydantic/item.py Outdated Show resolved Hide resolved
@vincentsarago
Copy link
Member Author

FYI: I've moved everything in StacCommonMetadata because there is no real need to change datetime in ItemProperties

@vincentsarago vincentsarago mentioned this pull request May 21, 2024
Closed
@vincentsarago vincentsarago requested a review from gadomski May 21, 2024 09:33
@vincentsarago vincentsarago merged commit f09aeda into main May 21, 2024
5 checks passed
@vincentsarago vincentsarago deleted the patch/allow-null-datetime branch May 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error with null datetime
2 participants
@vincentsarago @gadomski