Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #77, we should permit a None value for datetime property under certain circumstances.
By the time we are running our validators, we are validating against a Python dictionary (ie not a JSON string). For this reason, we should be permitting
None
values forproperties.datetime
whenproperties.start_datetime
andproperties.end_datetime
are provided.Going a bit further, I'm not sure that it's correct for us to permit
properties.datetime
to ever equal"null"
(as is currently supported). The STAC Spec states thatnull
is sometimes permitted, however"null"
is never mentioned as being permitted.closes #77
Before:
After: