-
Notifications
You must be signed in to change notification settings - Fork 207
feat: improve lifecycle management #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c99c0b0 to
03b09d2
Compare
03b09d2 to
06abe6f
Compare
06abe6f to
3dbe570
Compare
|
Thanks for looking into this. This makes sense. Only thing I need to work with this is the |
677d841 to
5ca7270
Compare
|
Also changed the |
|
Nice, I'll take it for a quick spin in the morning and check what I need to do for opencode, but this should be fine. |
|
Sorry I've broken this |
I'll take a look at it tomorrow, no worries! |
Fixes #248.
Changes
Core
exitSignalsoption to renderer, which specifies a list of signals that the renderer should destroy itself upon receiving.beforeExitevent. Theexitevent does not allow for more tasks to be added to the event loop, and thus theBun.sleep(200)call would be effectively ignored, preventing the captured logs from being dumped.React
createRootandrendermethods.rendermethods to make it easier to implement external lifecycle control.Solid
rendermethods to make it easier to implement external lifecycle control.createRoot#270 to the@opentui/solidpackage as well. This is helpful for lifecycle control because it inherently exposes therenderer(the user has to create one beforehand).createRootmethod already exists in thesolid-jspackage, which could create some confusion. Should I rename it? Open to suggestions!@opentui/solidexamples and README.md to reflect the new API.