fix(solid): Call lifecycle dispose on renderer.destroy #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
dispose()inonDestroyAddresses #288 for solidjs.
This is a proof of concept for fixing #288.A potential alternative would be to add a dispose or onDestroy parameter to
CliRendererConfig.I only added it to the solidjs testSetup because I currently need it to write the opencode TUI tests. After your feedback, I can also add it to the production solidjs
renderand react+vue (if applicable).