Skip to content

Conversation

@veracioux
Copy link
Contributor

@veracioux veracioux commented Nov 9, 2025

Changes:

  • Add onDestroy callback to CliRendererOptions
  • Call solidjs dispose() in onDestroy

Addresses #288 for solidjs.


This is a proof of concept for fixing #288.

A potential alternative would be to add a dispose or onDestroy parameter to CliRendererConfig.

I only added it to the solidjs testSetup because I currently need it to write the opencode TUI tests. After your feedback, I can also add it to the production solidjs render and react+vue (if applicable).

@veracioux veracioux marked this pull request as draft November 9, 2025 21:18
@veracioux veracioux force-pushed the fix/framework-lifecycle-dispose branch from 1a26ecc to 3f398e1 Compare November 9, 2025 22:58
@veracioux veracioux changed the title fix(solid): Call lifecycle dispose on testSetup.renderer.destroy fix(solid): Call lifecycle dispose on renderer.destroy Nov 12, 2025
@veracioux veracioux marked this pull request as ready for review November 12, 2025 09:45
Copy link
Collaborator

@kommander kommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will probably conflict with #302, but should be minor.

@kommander kommander merged commit 2ca546c into sst:main Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants