Skip to content

Add comprehensive parser test cases from ClickHouse official repository #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 5 commits into from
Dec 13, 2025
Merged

Add comprehensive parser test cases from ClickHouse official repository #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cec9520
Add comprehensive parser test cases from ClickHouse official repository
claude Dec 12, 2025
a804123
Refactor parser tests to use testdata directory structure
claude Dec 13, 2025
30cd2d0
Switch test metadata from YAML to JSON format
claude Dec 13, 2025
8b060a5
Fix infinite loop in parser for parametric function calls
claude Dec 13, 2025
c2fe226
Add 1 second timeout to each parser test
claude Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Empty file added go.sum
View file
Open in desktop
Empty file.
7 changes: 6 additions & 1 deletion parser/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package parser

import (
"fmt"
"strconv"
"strings"

Expand Down Expand Up @@ -163,7 +164,11 @@ func (p *Parser) parseInfixExpression(left ast.Expression) ast.Expression {
if ident, ok := left.(*ast.Identifier); ok {
return p.parseFunctionCall(ident.Name(), ident.Position)
}
return left
// Parametric function call like quantile(0.9)(number) - not yet supported
// Return nil to signal error and prevent infinite loop
p.errors = append(p.errors, fmt.Errorf("parametric function calls like func(params)(args) are not yet supported at line %d, column %d",
p.current.Pos.Line, p.current.Pos.Column))
return nil
case token.LBRACKET:
return p.parseArrayAccess(left)
case token.DOT:
Expand Down
Loading