Add comprehensive parser test cases from ClickHouse official repository #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 18 new test functions covering: - Basic expressions (arithmetic, WHERE, ORDER BY, LIMIT, CASE, etc.) - Window functions (OVER, PARTITION BY, ROWS/RANGE frames, named windows) - Join types (CROSS, INNER, LEFT, RIGHT, FULL, ANY, ALL, SEMI, ANTI, GLOBAL) - Subqueries (scalar, IN/NOT IN, EXISTS/NOT EXISTS) - Array functions (constructors, manipulation, lambda expressions) - Date/time functions (conversion, extraction, arithmetic) - String functions (manipulation, formatting, searching) - Type conversions (numeric, string, casting) - DDL statements (CREATE TABLE/VIEW/DATABASE, DROP, TRUNCATE, RENAME) - ALTER statements (columns, indexes, constraints, partitions, TTL) - INSERT statements (VALUES, SELECT, FORMAT) - OPTIMIZE, SHOW, DESCRIBE, USE, SET statements - SYSTEM commands (cache, merges, replicas) - EXPLAIN variants (AST, SYNTAX, PLAN, PIPELINE, ESTIMATE) - ClickHouse-specific features (ARRAY JOIN, PREWHERE, SAMPLE, FINAL, FORMAT, parametric aggregates, combinators, dictionaries, maps, JSON, regex, UUID, IP, URL, hash, encoding, bit functions) All queries validated against ClickHouse server (v25.12.1). Tests are designed as TODO items - they skip if parser doesn't support the feature yet, allowing incremental parser development.
- Move each test case to its own folder inside testdata/ - Each folder contains query.sql with the SQL query - Add metadata.yaml with todo: true for unsupported features - Add source key with URL for queries from ClickHouse repo - Create single TestParser function using subtests - Add TestParserWithClickHouse for server validation - Remove old individual test functions (reduced from 1594 to 257 lines) - Add yaml.v3 dependency for metadata parsing
- Convert metadata.yaml files to metadata.json - Update parser_test.go to use encoding/json instead of yaml.v3 - Remove gopkg.in/yaml.v3 dependency from go.mod - Simplifies dependencies by using only stdlib
- Fix parser hanging on queries like quantile(0.9)(number) - Return error instead of looping when LPAREN follows non-identifier - Remove ClickHouse integration test (TestParserWithClickHouse) - Add todo metadata for 10 failing test cases - Tests now complete in ~0.2s (well under 10s timeout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 18 new test functions covering:
FORMAT, parametric aggregates, combinators, dictionaries, maps, JSON,
regex, UUID, IP, URL, hash, encoding, bit functions)
All queries validated against ClickHouse server (v25.12.1).
Tests are designed as TODO items - they skip if parser doesn't support
the feature yet, allowing incremental parser development.