-
Notifications
You must be signed in to change notification settings - Fork 1.3k
DATAES-219 Developments for querydsl-elasticsearch integration. #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAES-219 Developments for querydsl-elasticsearch integration. #134
Conversation
5299781
to
0102bbd
Compare
This PR has very high quality. I'm not sure why there is no feedback on it for almost 50 days now. |
Ping @mohsinh. |
Hello, Currently the pull request can not be merged due to upgrade to elasticsearch 2.x. @gkathire proposed a pull request to https://github.com/querydsql/querydsl-contrib for elasticsearch 2.x. I'll ask @timowest to merge it in order to change this PR. @mohsinh, is it something we can discuss to merge ? PS: The querydsl-contrib PR : querydsl/querydsl-contrib#15 |
For more info please check - https://jira.spring.io/browse/DATAES-219 |
We are still waiting for QueryDSL team for release of 'querydsl-contrib' project. |
querydsl/querydsl-contrib#19 looks to have been merged, is there anything else blocking the support? |
There is, querydsl/querydsl-contrib#19 brought support for ES 2.x. And now spring-data-elasticsearch support ES 5.x. |
@olivergierke @kevinleturc |
closing this PR, as the latest supported version of Elasticsearch in Querydsl is 2.2.2 whic is not supported by Spring Data Elasticsearch anymore |
No description provided.