Skip to content

Changes to make querydsl-elasticsearch work with latest elasticsearch #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

gkathire
Copy link

This change contains

  • Fixes to make querydsl-elasticsearch to work with the latest elasticsearch 2.x
  • Added the String Contains Ignorecase criteria support

Except for the Package verification test case , other test cases passed.

Let me know if you need any other changes to this fix.

Guru Kathiresan added 2 commits December 30, 2015 19:15
 - Fixes to make querydsl-elasticsearch to work with the latest elasticsearch 2.x
 - Added the String Contains Ignorecase criteria support
@kevinleturc
Copy link
Contributor

Hello,

Changes to upgrade the elasticsearch version to 2.x will break backward compatibility, we need to keep the projet running on elasticsearch 1.x version for groupId/artificatId.
We can probably split the project into maven sub-mobules (as several classes are in common), for example :

  • querydsl-elasticsearch-parent
    • querydsl-elasticsearch-core
    • querydsl-elasticsearch
    • querydsl-elasticsearch2

@timowest : what do you think ? Is it better to copy the project and made proposed changes ?

For the new criteria support, it's ok for me.
Could you create a pull request with changes for new criteria support for elasticsearch 1.x ?

Regards

@gkathire
Copy link
Author

gkathire commented Jan 5, 2016

Sure, I can create a new pull request for the new criteria support. Since there are only 3 files in the project, i think we can make a copy of it and create a new querydsl-elasticsearch2 project. In that case we will have more freedom to make changes to the project with the new es2 specific changes without confined to the es1.x api. Let me know what to do and I can create a new pull request based on the suggestion.

@timowest
Copy link
Member

timowest commented Jan 5, 2016

I agree that a querydsl-elasticsearch2 project would be better

@kevinleturc
Copy link
Contributor

Regarding to spring-projects/spring-data-elasticsearch#134, can we merge this pull request ?
Unless we need to keep elasticsearch 1.x compatibility ?

@gkathire
Copy link
Author

gkathire commented Apr 6, 2016

If you use the patch from #16 , you dont have to upgrade the elastic search. It contains support for elasticsearch-2 support as a new library.

@timowest
Copy link
Member

Closing in favor of #19

@timowest timowest closed this Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants