Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better TypeId #209

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Yeah this probs won't work

c2099c1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Better TypeId #209

Yeah this probs won't work
c2099c1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Dec 25, 2023 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 30 in src/type/specta_id.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

single-character string constant used as pattern

warning: single-character string constant used as pattern
  --> src/type/specta_id.rs:30:42
   |
30 |         let end_offset = type_name.rfind("<").unwrap_or(type_name.len());
   |                                          ^^^ help: try using a `char` instead: `'<'`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
   = note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::all)]`

Check warning on line 138 in src/lang/ts/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

calling `push_str()` using a single-character string literal

warning: calling `push_str()` using a single-character string literal
   --> src/lang/ts/mod.rs:138:5
    |
138 |     s.push_str(";");
    |     ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(';')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str

Check warning on line 131 in src/lang/ts/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

calling `push_str()` using a single-character string literal

warning: calling `push_str()` using a single-character string literal
   --> src/lang/ts/mod.rs:131:5
    |
131 |     s.push_str(")");
    |     ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(')')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str

Check warning on line 121 in src/lang/ts/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

calling `push_str()` using a single-character string literal

warning: calling `push_str()` using a single-character string literal
   --> src/lang/ts/mod.rs:121:5
    |
121 |     s.push_str("(");
    |     ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('(')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
    = note: `#[warn(clippy::single_char_add_str)]` implied by `#[warn(clippy::all)]`

Check warning on line 211 in src/internal.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> src/internal.rs:202:5
    |
202 | /     pub fn get_fn_datatype<TMarker, T: SpectaFunction<TMarker>>(
203 | |         _: T,
204 | |         asyncness: bool,
205 | |         name: Cow<'static, str>,
...   |
210 | |         no_return_type: bool,
211 | |     ) -> FunctionDataType {
    | |_________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
note: the lint level is defined here
   --> src/lib.rs:3:9
    |
3   | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs
    |         ^^^^^^^^^^^
    = note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]`

Check warning on line 66 in src/lang/ts/reserved_terms.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

constant `RESERVED_IDENTS` is never used

warning: constant `RESERVED_IDENTS` is never used
  --> src/lang/ts/reserved_terms.rs:66:18
   |
66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[
   |                  ^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default