Skip to content

Better TypeId

Better TypeId #359

Triggered via pull request December 25, 2023 15:28
Status Failure
Total duration 5m 19s
Artifacts

ci.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 7 warnings
build (macos-latest)
Process completed with exit code 101.
build (windows-latest)
The job was canceled because "macos-latest" failed.
build (windows-latest)
The operation was canceled.
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
build (ubuntu-latest)
The operation was canceled.
single-character string constant used as pattern: src/type/specta_id.rs#L30
warning: single-character string constant used as pattern --> src/type/specta_id.rs:30:42 | 30 | let end_offset = type_name.rfind("<").unwrap_or(type_name.len()); | ^^^ help: try using a `char` instead: `'<'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::all)]`
calling `push_str()` using a single-character string literal: src/lang/ts/mod.rs#L138
warning: calling `push_str()` using a single-character string literal --> src/lang/ts/mod.rs:138:5 | 138 | s.push_str(";"); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(';')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
calling `push_str()` using a single-character string literal: src/lang/ts/mod.rs#L131
warning: calling `push_str()` using a single-character string literal --> src/lang/ts/mod.rs:131:5 | 131 | s.push_str(")"); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(')')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
calling `push_str()` using a single-character string literal: src/lang/ts/mod.rs#L121
warning: calling `push_str()` using a single-character string literal --> src/lang/ts/mod.rs:121:5 | 121 | s.push_str("("); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('(')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `#[warn(clippy::single_char_add_str)]` implied by `#[warn(clippy::all)]`
this function has too many arguments (8/7): src/internal.rs#L202
warning: this function has too many arguments (8/7) --> src/internal.rs:202:5 | 202 | / pub fn get_fn_datatype<TMarker, T: SpectaFunction<TMarker>>( 203 | | _: T, 204 | | asyncness: bool, 205 | | name: Cow<'static, str>, ... | 210 | | no_return_type: bool, 211 | | ) -> FunctionDataType { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments note: the lint level is defined here --> src/lib.rs:3:9 | 3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs | ^^^^^^^^^^^ = note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]`
constant `RESERVED_IDENTS` is never used: src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used --> src/lang/ts/reserved_terms.rs:66:18 | 66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[ | ^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/