Fix cache race status

.github/workflows/pull_request.yaml

@@ -20,7 +20,7 @@ jobs:
     - name: Set up Go 1.14
       uses: actions/setup-go@v2
       with:
-        go-version: 1.14
+        go-version: 1.14.3
     - uses: engineerd/[email protected]
       with:
         skipClusterCreation: "true"
@@ -41,10 +41,11 @@ jobs:
     - name: Setup env
       env:
         KUBECTL: ${{ steps.kubectl.outputs.kubectl-path }}
+        ISTIO_VERSION: "1.6.0-rc.2"
       run: |
         curl -sSL https://get.helm.sh/helm-v3.2.0-linux-amd64.tar.gz | tar -xzf - linux-amd64/helm
-        curl -sSL https://github.com/istio/istio/releases/download/1.5.1/istio-1.5.1-linux.tar.gz | tar -xzf - istio-1.5.1/bin/istioctl
-        export PATH=$PWD/istio-1.5.1/bin:$PWD/linux-amd64:$(dirname $KUBECTL):$PATH
+        curl -sSL https://github.com/istio/istio/releases/download/${ISTIO_VERSION}/istio-${ISTIO_VERSION}-linux-amd64.tar.gz | tar -xzf - istio-${ISTIO_VERSION}/bin/istioctl
+        export PATH=$PWD/istio-${ISTIO_VERSION}/bin:$PWD/linux-amd64:$(dirname $KUBECTL):$PATH
         go get -u github.com/onsi/ginkgo/ginkgo
         make install-deps
         ./ci/setup-kind.sh

Makefile

@@ -44,8 +44,7 @@ install-deps: mod-download
 	go get -v github.com/solo-io/[email protected]
 	go get -v github.com/golang/mock/[email protected]
 	go get -v golang.org/x/tools/cmd/[email protected]
-	go get -v github.com/cratonica/2goarray
-	go mod tidy
+	go get -v github.com/cratonica/2goarray@514510793eaa1ae2cc2217a9a743104312412f35
 
 
 

changelog/v0.0.34/use-http-cache.yaml

@@ -0,0 +1,4 @@
+changelog:
+  - type: FIX
+    description: Use HTTP cache instead of a file cache; this should solve file races and pod restart issues.
+    issueLink: https://github.com/solo-io/wasme/issues/104

docs/content/reference/cli/wasme_deploy_istio.md

@@ -19,7 +19,7 @@ Note: currently only Istio 1.5.x is supported.
 
 
 ```
-wasme deploy istio <image> --id=<unique name> [--config=<inline string>] [--root-id=<root id>] [--namespaces <comma separated namespaces>] [flags]
+wasme deploy istio <image> --id=<unique name> [--config=<inline string>] [--root-id=<root id>] [--namespaces <comma separated namespaces>] [--labels deployment-label-key=value] [flags]
 ```
 
 ### Options
@@ -32,6 +32,7 @@ wasme deploy istio <image> --id=<unique name> [--config=<inline string>] [--root
       --cache-repo string                name of the image repository to use for the cache server daemonset (default "quay.io/solo-io/wasme")
       --cache-tag string                 image tag to use for the cache server daemonset (default "dev")
       --cache-timeout duration           the length of time to wait for the server-side filter cache to pull the filter image before giving up with an error. set to 0 to skip the check entirely (note, this may produce a known race condition). (default 1m0s)
+      --dry-run                          print output any configuration changes to stdout rather than applying them to the target file / kubernetes cluster
   -h, --help                             help for istio
       --istio-namespace string           the namespace where the Istio control plane is installed (default "istio-system")
   -l, --labels stringToString            labels of the deployment or daemonset into which to inject the filter. if not set, will apply to all workloads in the target namespace (default [])

go.mod

@@ -5,10 +5,11 @@ go 1.13
 require (
 	github.com/avast/retry-go v2.4.3+incompatible
 	github.com/containerd/containerd v1.3.0
+	github.com/containerd/fifo v0.0.0-20200410184934-f15a3290365b // indirect
 	github.com/deislabs/oras v0.7.0
 	github.com/docker/cli v0.0.0-20191017083524-a8ff7f821017
 	github.com/docker/distribution v2.7.1+incompatible
-	github.com/docker/docker v1.13.1 // indirect
+	github.com/docker/docker v1.13.1
 	github.com/elazarl/goproxy v0.0.0-20190421051319-9d40249d3c2f // indirect
 	github.com/elazarl/goproxy/ext v0.0.0-20190421051319-9d40249d3c2f // indirect
 	github.com/envoyproxy/go-control-plane v0.9.6-0.20200401235947-be7fefdaf0df
@@ -28,14 +29,14 @@ require (
 	github.com/opencontainers/go-digest v1.0.0-rc1
 	github.com/opencontainers/image-spec v1.0.1
 	github.com/opencontainers/runc v1.0.0-rc9 // indirect
-	github.com/pkg/errors v0.8.1
+	github.com/pkg/errors v0.9.1
 	github.com/pseudomuto/protoc-gen-doc v1.3.0
 	github.com/pseudomuto/protokit v0.2.0
 	github.com/sirupsen/logrus v1.4.2
 	github.com/solo-io/gloo v1.3.5
 	github.com/solo-io/go-utils v0.15.2
-	github.com/solo-io/protoc-gen-ext v0.0.7
-	github.com/solo-io/skv2 v0.0.5
+	github.com/solo-io/protoc-gen-ext v0.0.9
+	github.com/solo-io/skv2 v0.2.2
 	github.com/solo-io/solo-kit v0.13.5
 	github.com/spf13/cobra v0.0.5
 	github.com/spf13/pflag v1.0.5