Fix cache race status #95
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilackarms
reviewed
Apr 13, 2020
pkg/deploy/istio/istio_provider.go
Outdated
| SocketAddress: &envoy_api_v2_core.SocketAddress{ | ||
| Address: p.Cache.Name + "." + p.Cache.Namespace + ".svc.cluster.local", // do we need the suffix svc.cluster.local? | ||
| PortSpecifier: &envoy_api_v2_core.SocketAddress_PortValue{ | ||
| PortValue: 9979, |
ilackarms
reviewed
Apr 13, 2020
pkg/deploy/istio/istio_provider.go
Outdated
| } | ||
| case WorkloadTypeDaemonSet: | ||
| workloads, err := p.KubeClient.AppsV1().DaemonSets(p.Workload.Namespace).List(metav1.ListOptions{ | ||
| workloads, err := p.KubeClient.AppsV1().Deployments(p.Workload.Namespace).List(metav1.ListOptions{ |
ilackarms
reviewed
Apr 13, 2020
| @@ -125,10 +128,25 @@ func (c *CacheImpl) Get(ctx context.Context, digest digest.Digest) (model.Filter | |||
| } | |||
|
|
|||
| func (c *CacheImpl) ServeHTTP(rw http.ResponseWriter, r *http.Request) { | |||
| _, file := path.Split(r.URL.Path) | |||
| switch { | |||
| case len(file) == hex.EncodedLen(crypto.SHA256.Size()): | |||
There was a problem hiding this comment.
add comment for gloo backwards-compatibility (and maybe deprecate at some pt)?
ilackarms
reviewed
Apr 13, 2020
pkg/cache/deploy.go
Outdated
| _, err := d.kube.AppsV1().DaemonSets(d.namespace).Create(desiredDaemonSet) | ||
| // update on already exists err | ||
| _, err := d.kube.AppsV1().Deployments(d.namespace).Create(desiredDeployment) | ||
| // update don already exists err |
|
Issues linked to changelog: |
|
this will be flaky untill istio 1.8 is out |
added 14 commits
October 12, 2020 14:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOT NOTES:
resolves #104